Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
08421cb6
Commit
08421cb6
authored
Mar 07, 2022
by
wortschi
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove load_balancing_for_export_workers ff
parent
fb0e0a16
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
29 deletions
+3
-29
config/feature_flags/development/load_balancing_for_export_workers.yml
...e_flags/development/load_balancing_for_export_workers.yml
+0
-8
lib/gitlab/import_export/json/streaming_serializer.rb
lib/gitlab/import_export/json/streaming_serializer.rb
+0
-2
spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb
...ib/gitlab/import_export/json/streaming_serializer_spec.rb
+3
-19
No files found.
config/feature_flags/development/load_balancing_for_export_workers.yml
deleted
100644 → 0
View file @
fb0e0a16
---
name
:
load_balancing_for_export_workers
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68153
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/338615
milestone
:
'
14.2'
type
:
development
group
:
group::import
default_enabled
:
false
lib/gitlab/import_export/json/streaming_serializer.rb
View file @
08421cb6
...
...
@@ -166,8 +166,6 @@ module Gitlab
end
def
read_from_replica_if_available
(
&
block
)
return
yield
unless
::
Feature
.
enabled?
(
:load_balancing_for_export_workers
,
type: :development
,
default_enabled: :yaml
)
::
Gitlab
::
Database
::
LoadBalancing
::
Session
.
current
.
use_replicas_for_read_queries
(
&
block
)
end
end
...
...
spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb
View file @
08421cb6
...
...
@@ -158,26 +158,10 @@ RSpec.describe Gitlab::ImportExport::Json::StreamingSerializer do
end
describe
'load balancing'
do
context
'when feature flag load_balancing_for_export_workers is enabled'
do
before
do
stub_feature_flags
(
load_balancing_for_export_workers:
true
)
end
it
'reads from replica'
do
expect
(
Gitlab
::
Database
::
LoadBalancing
::
Session
.
current
).
to
receive
(
:use_replicas_for_read_queries
).
and_call_original
subject
.
execute
end
end
it
'reads from replica'
do
expect
(
Gitlab
::
Database
::
LoadBalancing
::
Session
.
current
).
to
receive
(
:use_replicas_for_read_queries
).
and_call_original
context
'when feature flag load_balancing_for_export_workers is disabled'
do
it
'reads from primary'
do
stub_feature_flags
(
load_balancing_for_export_workers:
false
)
expect
(
Gitlab
::
Database
::
LoadBalancing
::
Session
.
current
).
not_to
receive
(
:use_replicas_for_read_queries
)
subject
.
execute
end
subject
.
execute
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment