Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
086220f5
Commit
086220f5
authored
Jan 09, 2020
by
Tiger
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unused keyword from EKS provision service
parent
27757f46
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
3 deletions
+7
-3
app/services/clusters/aws/provision_service.rb
app/services/clusters/aws/provision_service.rb
+1
-2
changelogs/unreleased/121751-new-eks-cluster-results-in-error-unknown-keyword-region.yml
...w-eks-cluster-results-in-error-unknown-keyword-region.yml
+5
-0
spec/services/clusters/aws/provision_service_spec.rb
spec/services/clusters/aws/provision_service_spec.rb
+1
-1
No files found.
app/services/clusters/aws/provision_service.rb
View file @
086220f5
...
...
@@ -38,8 +38,7 @@ module Clusters
def
credentials
@credentials
||=
Clusters
::
Aws
::
FetchCredentialsService
.
new
(
provision_role
,
provider:
provider
,
region:
provider
.
region
provider:
provider
).
execute
end
...
...
changelogs/unreleased/121751-new-eks-cluster-results-in-error-unknown-keyword-region.yml
0 → 100644
View file @
086220f5
---
title
:
Remove unused keyword from EKS provision service
merge_request
:
22633
author
:
type
:
fixed
spec/services/clusters/aws/provision_service_spec.rb
View file @
086220f5
...
...
@@ -35,7 +35,7 @@ describe Clusters::Aws::ProvisionService do
before
do
allow
(
Clusters
::
Aws
::
FetchCredentialsService
).
to
receive
(
:new
)
.
with
(
provision_role
,
provider:
provider
,
region:
provider
.
region
)
.
with
(
provision_role
,
provider:
provider
)
.
and_return
(
double
(
execute:
credentials
))
allow
(
provider
).
to
receive
(
:api_client
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment