Merge branch 'nicolasdular/cleanup-pipelines-empty-state-experiment' into 'master'

Change pipeline empty state language

See merge request gitlab-org/gitlab!53281

app/assets/javascripts/pipelines/components/pipelines_list/empty_state.vue

 <script>
 import { GlButton } from '@gitlab/ui';
-import { isExperimentEnabled } from '~/lib/utils/experimentation';
 import { s__ } from '~/locale';
-import Tracking from '~/tracking';
 
 export default {
   i18n: {
-    control: {
-      infoMessage: s__(`Pipelines|Continuous Integration can help
-        catch bugs by running your tests automatically,
-        while Continuous Deployment can help you deliver
-        code to your product environment.`),
-      buttonMessage: s__('Pipelines|Get started with Pipelines'),
-    },
-    experiment: {
-      infoMessage: s__(`Pipelines|GitLab CI/CD can automatically build,
+    infoMessage: s__(`Pipelines|GitLab CI/CD can automatically build,
           test, and deploy your code. Let GitLab take care of time
           consuming tasks, so you can spend more time creating.`),
-      buttonMessage: s__('Pipelines|Get started with CI/CD'),
-    },
+    buttonMessage: s__('Pipelines|Get started with CI/CD'),
   },
   name: 'PipelinesEmptyState',
   components: {
@@ -38,23 +27,6 @@ export default {
       required: true,
     },
   },
-  mounted() {
-    this.track('viewed');
-  },
-  methods: {
-    track(action) {
-      if (!gon.tracking_data) {
-        return;
-      }
-
-      const { category, value, label, property } = gon.tracking_data;
-
-      Tracking.event(category, action, { value, label, property });
-    },
-    isExperimentEnabled() {
-      return isExperimentEnabled('pipelinesEmptyState');
-    },
-  },
 };
 </script>
 <template>
@@ -70,11 +42,7 @@ export default {
             {{ s__('Pipelines|Build with confidence') }}
           </h4>
           <p data-testid="info-text">
-            {{
-              isExperimentEnabled()
-                ? $options.i18n.experiment.infoMessage
-                : $options.i18n.control.infoMessage
-            }}
+            {{ $options.i18n.infoMessage }}
           </p>
 
           <div class="gl-text-center">
@@ -83,13 +51,8 @@ export default {
               variant="info"
               category="primary"
               data-testid="get-started-pipelines"
-              @click="track('documentation_clicked')"
             >
-              {{
-                isExperimentEnabled()
-                  ? $options.i18n.experiment.buttonMessage
-                  : $options.i18n.control.buttonMessage
-              }}
+              {{ $options.i18n.buttonMessage }}
             </gl-button>
           </div>
         </template>

app/controllers/projects/pipelines_controller.rb

@@ -20,7 +20,6 @@ class Projects::PipelinesController < Projects::ApplicationController
     push_frontend_feature_flag(:jira_for_vulnerabilities, project, type: :development, default_enabled: :yaml)
   end
   before_action :ensure_pipeline, only: [:show]
-  before_action :push_experiment_to_gon, only: :index, if: :html_request?
 
   # Will be removed with https://gitlab.com/gitlab-org/gitlab/-/issues/225596
   before_action :redirect_for_legacy_scope_filter, only: [:index], if: -> { request.format.html? }
@@ -45,11 +44,7 @@ class Projects::PipelinesController < Projects::ApplicationController
     @pipelines_count = limited_pipelines_count(project)
 
     respond_to do |format|
-      format.html do
-        record_empty_pipeline_experiment
-
-        render :index
-      end
+      format.html
       format.json do
         Gitlab::PollingInterval.set_header(response, interval: POLLING_INTERVAL)
 
@@ -300,20 +295,6 @@ class Projects::PipelinesController < Projects::ApplicationController
   def index_params
     params.permit(:scope, :username, :ref, :status)
   end
-
-  def record_empty_pipeline_experiment
-    return unless @pipelines_count.to_i == 0
-    return if helpers.has_gitlab_ci?(@project)
-
-    record_experiment_user(:pipelines_empty_state)
-  end
-
-  def push_experiment_to_gon
-    return unless current_user
-
-    push_frontend_experiment(:pipelines_empty_state, subject: current_user)
-    frontend_experimentation_tracking_data(:pipelines_empty_state, 'view', project.namespace_id, subject: current_user)
-  end
 end
 
 Projects::PipelinesController.prepend_if_ee('EE::Projects::PipelinesController')

app/services/ci/create_pipeline_service.rb

@@ -123,7 +123,6 @@ module Ci
 
     def record_conversion_event
       Experiments::RecordConversionEventWorker.perform_async(:ci_syntax_templates, current_user.id)
-      Experiments::RecordConversionEventWorker.perform_async(:pipelines_empty_state, current_user.id)
     end
 
     def create_namespace_onboarding_action

changelogs/unreleased/nicolasdular-cleanup-pipelines-empty-state-experiment.yml

+---
+title: Change pipeline empty state language
+merge_request: 53281
+author:
+type: changed

config/feature_flags/experiment/pipelines_empty_state_experiment_percentage.yml

----
-name: pipelines_empty_state_experiment_percentage
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/47952
-rollout_issue_url: https://gitlab.com/gitlab-org/growth/team-tasks/-/issues/289
-milestone: '13.8'
-type: experiment
-group: group::activation
-default_enabled: false

lib/gitlab/experimentation.rb

@@ -92,10 +92,6 @@ module Gitlab
         tracking_category: 'Growth::Activation::Experiment::CiSyntaxTemplates',
         rollout_strategy: :user
       },
-      pipelines_empty_state: {
-        tracking_category: 'Growth::Activation::Experiment::PipelinesEmptyState',
-        rollout_strategy: :user
-      },
       invite_members_new_dropdown: {
         tracking_category: 'Growth::Expansion::Experiment::InviteMembersNewDropdown'
       },

locale/gitlab.pot

@@ -21461,9 +21461,6 @@ msgstr ""
 msgid "Pipelines|Clear Runner Caches"
 msgstr ""
 
-msgid "Pipelines|Continuous Integration can help catch bugs by running your tests automatically, while Continuous Deployment can help you deliver code to your product environment."
-msgstr ""
-
 msgid "Pipelines|Copy trigger token"
 msgstr ""
 

spec/controllers/projects/pipelines_controller_spec.rb

@@ -272,72 +272,6 @@ RSpec.describe Projects::PipelinesController do
     end
   end
 
-  describe 'GET #index' do
-    subject(:request) { get :index, params: { namespace_id: project.namespace, project_id: project } }
-
-    context 'experiment not active' do
-      it 'does not push tracking_data to gon' do
-        request
-
-        expect(Gon.tracking_data).to be_nil
-      end
-
-      it 'does not record experiment_user' do
-        expect { request }.not_to change(ExperimentUser, :count)
-      end
-    end
-
-    context 'when experiment active' do
-      before do
-        stub_experiment(pipelines_empty_state: true)
-        stub_experiment_for_subject(pipelines_empty_state: true)
-      end
-
-      it 'pushes tracking_data to Gon' do
-        request
-
-        expect(Gon.experiments["pipelinesEmptyState"]).to eq(true)
-        expect(Gon.tracking_data).to match(
-          {
-            category: 'Growth::Activation::Experiment::PipelinesEmptyState',
-            action: 'view',
-            label: anything,
-            property: 'experimental_group',
-            value: anything
-          }
-        )
-      end
-
-      context 'no pipelines created an no CI set up' do
-        before do
-          stub_application_setting(auto_devops_enabled: false)
-        end
-
-        it 'records experiment_user' do
-          expect { request }.to change(ExperimentUser, :count).by(1)
-        end
-      end
-
-      context 'CI set up' do
-        it 'does not record experiment_user' do
-          expect { request }.not_to change(ExperimentUser, :count)
-        end
-      end
-
-      context 'pipelines created' do
-        let!(:pipeline) { create(:ci_pipeline, project: project) }
-
-        before do
-          stub_application_setting(auto_devops_enabled: false)
-        end
-
-        it 'does not record experiment_user' do
-          expect { request }.not_to change(ExperimentUser, :count)
-        end
-      end
-    end
-  end
-
   describe 'GET show.json' do
     let(:pipeline) { create(:ci_pipeline, project: project) }
 

spec/frontend/pipelines/empty_state_spec.js

 import { shallowMount } from '@vue/test-utils';
-import { withGonExperiment } from 'helpers/experimentation_helper';
 import EmptyState from '~/pipelines/components/pipelines_list/empty_state.vue';
-import Tracking from '~/tracking';
 
 describe('Pipelines Empty State', () => {
   let wrapper;
@@ -40,104 +38,15 @@ describe('Pipelines Empty State', () => {
       expect(findGetStartedButton().attributes('href')).toBe('foo');
     });
 
-    describe('when in control group', () => {
-      it('should render empty state information', () => {
-        expect(findInfoText()).toContain(
-          'Continuous Integration can help catch bugs by running your tests automatically',
-          'while Continuous Deployment can help you deliver code to your product environment',
-        );
-      });
-
-      it('should render a button', () => {
-        expect(findGetStartedButton().text()).toBe('Get started with Pipelines');
-      });
-    });
-
-    describe('when in experiment group', () => {
-      withGonExperiment('pipelinesEmptyState');
-
-      beforeEach(() => {
-        createWrapper();
-      });
-
-      it('should render empty state information', () => {
-        expect(findInfoText()).toContain(
-          'GitLab CI/CD can automatically build, test, and deploy your code. Let GitLab take care of time',
-          'consuming tasks, so you can spend more time creating',
-        );
-      });
-
-      it('should render button text', () => {
-        expect(findGetStartedButton().text()).toBe('Get started with CI/CD');
-      });
+    it('should render empty state information', () => {
+      expect(findInfoText()).toContain(
+        'GitLab CI/CD can automatically build, test, and deploy your code. Let GitLab take care of time',
+        'consuming tasks, so you can spend more time creating',
+      );
     });
 
-    describe('tracking', () => {
-      let origGon;
-
-      describe('when data is set', () => {
-        beforeEach(() => {
-          jest.spyOn(Tracking, 'event').mockImplementation(() => {});
-          origGon = window.gon;
-
-          window.gon = {
-            tracking_data: {
-              category: 'Growth::Activation::Experiment::PipelinesEmptyState',
-              value: 1,
-              property: 'experimental_group',
-              label: 'label',
-            },
-          };
-          createWrapper();
-        });
-
-        afterEach(() => {
-          window.gon = origGon;
-        });
-
-        it('tracks when mounted', () => {
-          expect(Tracking.event).toHaveBeenCalledWith(
-            'Growth::Activation::Experiment::PipelinesEmptyState',
-            'viewed',
-            {
-              value: 1,
-              label: 'label',
-              property: 'experimental_group',
-            },
-          );
-        });
-
-        it('tracks when button is clicked', () => {
-          findGetStartedButton().vm.$emit('click');
-
-          expect(Tracking.event).toHaveBeenCalledWith(
-            'Growth::Activation::Experiment::PipelinesEmptyState',
-            'documentation_clicked',
-            {
-              value: 1,
-              label: 'label',
-              property: 'experimental_group',
-            },
-          );
-        });
-      });
-
-      describe('when no data is defined', () => {
-        beforeEach(() => {
-          jest.spyOn(Tracking, 'event').mockImplementation(() => {});
-
-          createWrapper();
-        });
-
-        it('does not track on view', () => {
-          expect(Tracking.event).not.toHaveBeenCalled();
-        });
-
-        it('does not track when button is clicked', () => {
-          findGetStartedButton().vm.$emit('click');
-          expect(Tracking.event).not.toHaveBeenCalled();
-        });
-      });
+    it('should render button text', () => {
+      expect(findGetStartedButton().text()).toBe('Get started with CI/CD');
     });
   });
 });

spec/services/ci/create_pipeline_service_spec.rb

@@ -102,7 +102,6 @@ RSpec.describe Ci::CreatePipelineService do
       describe 'recording a conversion event' do
         it 'schedules a record conversion event worker' do
           expect(Experiments::RecordConversionEventWorker).to receive(:perform_async).with(:ci_syntax_templates, user.id)
-          expect(Experiments::RecordConversionEventWorker).to receive(:perform_async).with(:pipelines_empty_state, user.id)
 
           pipeline
         end