Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
09412931
Commit
09412931
authored
Nov 09, 2018
by
samdbeckham
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixes the view issue link in the GSD modal
Where GSD is the group security dashboard
parent
c756b66b
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
11 additions
and
6 deletions
+11
-6
ee/app/assets/javascripts/vue_shared/security_reports/components/modal.vue
...ascripts/vue_shared/security_reports/components/modal.vue
+1
-1
ee/app/assets/javascripts/vue_shared/security_reports/store/utils.js
...ts/javascripts/vue_shared/security_reports/store/utils.js
+1
-1
ee/changelogs/unreleased/8370-view-issue-button-doesn-t-work-in-dashboard-modal.yml
...370-view-issue-button-doesn-t-work-in-dashboard-modal.yml
+5
-0
ee/spec/javascripts/vue_shared/security_reports/store/utils_spec.js
...vascripts/vue_shared/security_reports/store/utils_spec.js
+4
-4
No files found.
ee/app/assets/javascripts/vue_shared/security_reports/components/modal.vue
View file @
09412931
...
...
@@ -249,7 +249,7 @@ export default {
<a
v-if=
"modal.vulnerability.hasIssue"
:href=
"modal.vulnerability.issue
Feedback && modal.vulnerability.issueF
eedback.issue_url"
:href=
"modal.vulnerability.issue
_feedback && modal.vulnerability.issue_f
eedback.issue_url"
rel=
"noopener noreferrer nofollow"
class=
"btn btn-success btn-inverted"
>
...
...
ee/app/assets/javascripts/vue_shared/security_reports/store/utils.js
View file @
09412931
...
...
@@ -31,7 +31,7 @@ function enrichVulnerabilityWithfeedback(vulnerability, feedback = []) {
return
{
...
vuln
,
hasIssue
:
true
,
issue
F
eedback
:
fb
,
issue
_f
eedback
:
fb
,
};
}
return
vuln
;
...
...
ee/changelogs/unreleased/8370-view-issue-button-doesn-t-work-in-dashboard-modal.yml
0 → 100644
View file @
09412931
---
title
:
Fixes the view issue button in the Group Security Dashboard
merge_request
:
8385
author
:
type
:
fixed
ee/spec/javascripts/vue_shared/security_reports/store/utils_spec.js
View file @
09412931
...
...
@@ -87,7 +87,7 @@ describe('security reports utils', () => {
expect
(
parsed
.
hasIssue
).
toEqual
(
true
);
expect
(
parsed
.
isDismissed
).
toEqual
(
true
);
expect
(
parsed
.
dismissalFeedback
).
toEqual
(
sastFeedbacks
[
0
]);
expect
(
parsed
.
issue
F
eedback
).
toEqual
(
sastFeedbacks
[
1
]);
expect
(
parsed
.
issue
_f
eedback
).
toEqual
(
sastFeedbacks
[
1
]);
});
});
...
...
@@ -129,7 +129,7 @@ describe('security reports utils', () => {
expect
(
parsed
.
hasIssue
).
toEqual
(
true
);
expect
(
parsed
.
isDismissed
).
toEqual
(
true
);
expect
(
parsed
.
dismissalFeedback
).
toEqual
(
dependencyScanningFeedbacks
[
0
]);
expect
(
parsed
.
issue
F
eedback
).
toEqual
(
dependencyScanningFeedbacks
[
1
]);
expect
(
parsed
.
issue
_f
eedback
).
toEqual
(
dependencyScanningFeedbacks
[
1
]);
});
});
...
...
@@ -165,7 +165,7 @@ describe('security reports utils', () => {
expect
(
parsed
.
hasIssue
).
toEqual
(
true
);
expect
(
parsed
.
isDismissed
).
toEqual
(
true
);
expect
(
parsed
.
dismissalFeedback
).
toEqual
(
containerScanningFeedbacks
[
0
]);
expect
(
parsed
.
issue
F
eedback
).
toEqual
(
containerScanningFeedbacks
[
1
]);
expect
(
parsed
.
issue
_f
eedback
).
toEqual
(
containerScanningFeedbacks
[
1
]);
});
});
...
...
@@ -180,7 +180,7 @@ describe('security reports utils', () => {
expect
(
parsed
.
hasIssue
).
toEqual
(
true
);
expect
(
parsed
.
isDismissed
).
toEqual
(
true
);
expect
(
parsed
.
dismissalFeedback
).
toEqual
(
dastFeedbacks
[
0
]);
expect
(
parsed
.
issue
F
eedback
).
toEqual
(
dastFeedbacks
[
1
]);
expect
(
parsed
.
issue
_f
eedback
).
toEqual
(
dastFeedbacks
[
1
]);
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment