Update specs for new permissions

And implement review feedback

ee/app/models/ee/project.rb

@@ -579,7 +579,7 @@ module EE
       # Checking both feature availability on the license, as well as the feature
       # flag, because we don't want to enable design_management by default on
       # on prem installs yet.
-      feature_available?(:design_management) && ::Feature.enabled?(:design_management)
+      feature_available?(:design_management) && ::Feature.enabled?(:design_management, self)
     end
 
     private

ee/spec/features/projects/issues/design_management/user_uploads_designs_spec.rb

 require 'spec_helper'
 
 describe 'User uploads new design', :js do
+  let(:user) { project.owner }
   let(:project) { create(:project_empty_repo, :public) }
   let(:issue) { create(:issue, project: project) }
 
   before do
-    visit project_issue_path(project, issue)
+    sign_in(user)
+  end
+
+  context "when the feature is available" do
+    before do
+      stub_licensed_features(design_management: true)
+
+      visit project_issue_path(project, issue)
 
-    click_link 'Designs'
+      click_link 'Designs'
+
+      wait_for_requests
+    end
 
-    wait_for_requests
+    it 'uploads design' do
+      attach_file(:design_file, logo_fixture, make_visible: true)
+
+      expect(page).to have_selector('.js-design-list-item', count: 6)
+
+      within first('#designs-tab .card') do
+        expect(page).to have_content('dk.png')
+        expect(page).to have_content('Updated just now')
+      end
+    end
   end
 
-  it 'uploads design' do
-    attach_file(:design_file, logo_fixture, make_visible: true)
+  context 'when the feature is not available' do
+    before do
+      stub_licensed_features(design_management: false)
 
-    expect(page).to have_selector('.js-design-list-item', count: 6)
+      visit project_issue_path(project, issue)
+    end
 
-    within first('#designs-tab .card') do
-      expect(page).to have_content('dk.png')
-      expect(page).to have_content('Updated just now')
+    it 'does not show the designs link' do
+      expect(page).not_to have_link('Designs')
     end
   end
 

ee/spec/features/projects/issues/design_management/user_views_design_spec.rb

@@ -5,6 +5,8 @@ describe 'User views issue designs', :js do
   let(:issue) { create(:issue, project: project) }
 
   before do
+    stub_licensed_features(design_management: true)
+
     visit project_issue_path(project, issue)
 
     click_link 'Designs'

ee/spec/features/projects/issues/design_management/user_views_designs_spec.rb

@@ -5,6 +5,8 @@ describe 'User views issue designs', :js do
   let(:issue) { create(:issue, project: project) }
 
   before do
+    stub_licensed_features(design_management: true)
+
     visit project_issue_path(project, issue)
 
     click_link 'Designs'

ee/spec/policies/design_management/design_policy_spec.rb

@@ -146,7 +146,7 @@ describe DesignManagement::DesignPolicy do
       context "for anonymous users" do
         let(:current_user) { nil }
 
-        it { is_expected.to be_disallowed(*design_abilities)}
+        it { is_expected.to be_disallowed(*design_abilities) }
       end
     end
   end

spec/graphql/types/permission_types/issue_spec.rb

@@ -7,6 +7,8 @@ describe Types::PermissionTypes::Issue do
       :create_note, :reopen_issue
     ]
 
-    expect(described_class).to have_graphql_fields(expected_permissions)
+    expected_permissions.each do |permission|
+      expect(described_class).to have_graphql_field(permission)
+    end
   end
 end