Commit 09ffd672 authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets

Merge branch 'jira_mentionable' into 'master'

Fix JIRA issue reference bug
parents f1d32896 834b23a7
v 7.0.0 v 7.0.0
- Fix bug in JIRA Issue closing triggered by commit messages - Fix bug in JIRA Issue closing triggered by commit messages
- Fix JIRA issue reference bug
v 6.9.3 v 6.9.3
- Fix check CI status only when CI service is enabled(Daniel Aquino) - Fix check CI status only when CI service is enabled(Daniel Aquino)
......
...@@ -64,7 +64,8 @@ module Mentionable ...@@ -64,7 +64,8 @@ module Mentionable
return [] if text.blank? return [] if text.blank?
ext = Gitlab::ReferenceExtractor.new ext = Gitlab::ReferenceExtractor.new
ext.analyze(text) ext.analyze(text)
(ext.issues_for(p) + ext.merge_requests_for(p) + ext.commits_for(p)).uniq - [local_reference] issues = ext.issues_for(p).select { |issue| issue.is_a?(Issue) }
(issues + ext.merge_requests_for(p) + ext.commits_for(p)).uniq - [local_reference]
end end
# Create a cross-reference Note for each GFM reference to another Mentionable found in +mentionable_text+. # Create a cross-reference Note for each GFM reference to another Mentionable found in +mentionable_text+.
......
require 'spec_helper'
describe Mentionable do
include Mentionable
describe :references do
let(:project) { create(:project) }
it 'excludes JIRA references' do
project.stub(jira_tracker?: true)
references(project, 'JIRA-123').should be_empty
end
end
end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment