Commit 0a18edbd authored by Saikat Sarkar's avatar Saikat Sarkar

Merge branch 'vij-sort-members-by-activity' into 'master'

Allow billable member sorting by last activity

See merge request gitlab-org/gitlab!64620
parents 95d968b8 fb491cef
...@@ -9,7 +9,10 @@ module EE ...@@ -9,7 +9,10 @@ module EE
class << self class << self
def member_sort_options def member_sort_options
%w(access_level_asc access_level_desc last_joined name_asc name_desc oldest_joined oldest_sign_in recent_sign_in) %w[
access_level_asc access_level_desc last_joined name_asc name_desc oldest_joined oldest_sign_in
recent_sign_in last_activity_on_asc last_activity_on_desc
]
end end
end end
......
...@@ -38,7 +38,12 @@ RSpec.describe EE::API::Helpers::MembersHelpers do ...@@ -38,7 +38,12 @@ RSpec.describe EE::API::Helpers::MembersHelpers do
describe '.member_sort_options' do describe '.member_sort_options' do
it 'lists all keys available in group member view' do it 'lists all keys available in group member view' do
expect(described_class.member_sort_options).to match_array(member_sort_options_hash.keys) sort_options = %w[
access_level_asc access_level_desc last_joined name_asc name_desc oldest_joined
oldest_sign_in recent_sign_in last_activity_on_asc last_activity_on_desc
]
expect(described_class.member_sort_options).to match_array sort_options
end end
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment