Merge branch 'ee-remove_make_updated_cluster_applications' into 'master'

Remove #make_updated! as have #make_installed! now

See merge request gitlab-org/gitlab-ee!9476

app/models/clusters/concerns/application_status.rb

@@ -41,11 +41,6 @@ module Clusters
             transition [:installed, :updated, :update_errored, :scheduled] => :updating
           end
 
-          # Deprecated
-          event :make_updated do
-            transition [:updating] => :updated
-          end
-
           event :make_update_errored do
             transition any => :update_errored
           end

ee/app/services/clusters/applications/check_upgrade_progress_service.rb

@@ -21,7 +21,7 @@ module Clusters
       private
 
       def on_success
-        app.make_updated!
+        app.make_installed!
       ensure
         remove_pod
       end

spec/support/shared_examples/models/cluster_application_status_shared_examples.rb

@@ -80,36 +80,6 @@ shared_examples 'cluster application status specs' do |application_name|
       end
     end
 
-    describe '#make_updated' do
-      subject { create(application_name, :updating) }
-
-      it 'is updated' do
-        subject.make_updated!
-
-        expect(subject).to be_updated
-      end
-
-      it 'updates helm version' do
-        subject.cluster.application_helm.update!(version: '1.2.3')
-
-        subject.make_updated!
-
-        subject.cluster.application_helm.reload
-
-        expect(subject.cluster.application_helm.version).to eq(Gitlab::Kubernetes::Helm::HELM_VERSION)
-      end
-
-      it 'updates the version for the application' do
-        subject.update!(version: '0.0.0')
-
-        subject.make_updated!
-
-        subject.reload
-
-        expect(subject.version).to eq(subject.class.const_get(:VERSION))
-      end
-    end
-
     describe '#make_errored' do
       subject { create(application_name, :installing) }
       let(:reason) { 'some errors' }