Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0bb460bc
Commit
0bb460bc
authored
Jun 04, 2021
by
Zack Cuddy
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Changes based on @treagitlab feedback
Rename new_node_link to add_site_button in specs.
parent
35e5f26a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
4 additions
and
4 deletions
+4
-4
ee/app/assets/javascripts/geo_nodes_beta/components/app.vue
ee/app/assets/javascripts/geo_nodes_beta/components/app.vue
+1
-1
ee/spec/features/admin/geo/admin_geo_nodes_spec.rb
ee/spec/features/admin/geo/admin_geo_nodes_spec.rb
+1
-1
qa/qa/ee/page/admin/geo/nodes/show.rb
qa/qa/ee/page/admin/geo/nodes/show.rb
+2
-2
No files found.
ee/app/assets/javascripts/geo_nodes_beta/components/app.vue
View file @
0bb460bc
...
...
@@ -93,7 +93,7 @@ export default {
variant=
"confirm"
:href=
"newNodeUrl"
target=
"_blank"
data-qa-selector=
"
new_node_link
"
data-qa-selector=
"
add_site_button
"
>
{{ $options.i18n.addSite }}
</gl-button>
</div>
...
...
ee/spec/features/admin/geo/admin_geo_nodes_spec.rb
View file @
0bb460bc
...
...
@@ -38,7 +38,7 @@ RSpec.describe 'admin Geo Nodes', :js, :geo do
wait_for_requests
end
it
'shows all public Geo Nodes and
create new nod
e link'
do
it
'shows all public Geo Nodes and
Add sit
e link'
do
expect
(
page
).
to
have_link
(
'Add site'
,
href:
new_admin_geo_node_path
)
page
.
within
(
find
(
'.geo-node-core-details-grid-columns'
,
match: :first
))
do
expect
(
page
).
to
have_content
(
geo_node
.
url
)
...
...
qa/qa/ee/page/admin/geo/nodes/show.rb
View file @
0bb460bc
...
...
@@ -8,11 +8,11 @@ module QA
module
Nodes
class
Show
<
QA
::
Page
::
Base
view
'ee/app/assets/javascripts/geo_nodes_beta/components/app.vue'
do
element
:
new_node_link
element
:
add_site_button
end
def
new_node!
click_element
:new_node_link
click_element
(
:add_site_button
)
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment