Refactored tests, better view restrictions, and moved the message generator to a helper.

app/helpers/projects_helper.rb

@@ -220,6 +220,10 @@ module ProjectsHelper
     "The total size of this project's repository #{show_lfs} will be limited to this size. 0 for unlimited. Leave empty to inherit the group/global value."
   end
 
+  def project_above_size_limit_message
+    Gitlab::RepositorySizeError.new(@project).above_size_limit_message
+  end
+
   def git_user_name
     if current_user
       current_user.name

app/views/projects/_over_size_limit_warning.html.haml → app/views/projects/_above_size_limit_warning.html.haml

 .alert.alert-warning.hidden-xs
-  = Gitlab::RepositorySizeError.new(@project).over_size_limit_message
+  = project_above_size_limit_message

app/views/projects/show.html.haml

@@ -8,9 +8,8 @@
   - if current_user && can?(current_user, :download_code, @project)
     = render 'shared/no_ssh'
     = render 'shared/no_password'
-
-  - if @project.above_size_limit?
-    = render 'over_size_limit_warning'
+    - if @project.above_size_limit?
+      = render 'above_size_limit_warning'
 
 = render 'projects/last_push'
 = render "home_panel"

lib/gitlab/repository_size_error.rb

 module Gitlab
-  class RepositorySizeError < StandardError
+  class RepositorySizeError
     include ActionView::Helpers
 
     attr_reader :project
@@ -32,7 +32,7 @@ module Gitlab
       'Please contact your GitLab administrator for more information.'
     end
 
-    def over_size_limit_message
+    def above_size_limit_message
       "#{to_s} You won't be able to push new code to this project. #{more_info_message}"
     end
 

spec/controllers/projects_controller_spec.rb

@@ -92,15 +92,22 @@ describe ProjectsController do
 
       context 'project repo over limit' do
         before do
-          sign_in(user)
           allow_any_instance_of(Project).to receive(:above_size_limit?).and_return(true)
           project.team << [user, :master]
         end
 
-        it 'shows the over size limit warning message' do
+        it 'shows the over size limit warning message for project members' do
+          allow(controller).to receive(:current_user).and_return(user)
+
+          get :show, namespace_id: project.namespace.path, id: project.path
+
+          expect(response).to render_template('_above_size_limit_warning')
+        end
+
+        it 'does not show the message for non members' do
           get :show, namespace_id: project.namespace.path, id: project.path
 
-          expect(response).to render_template('_over_size_limit_warning')
+          expect(response).not_to render_template('_above_size_limit_warning')
         end
       end
     end