Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0c93e470
Commit
0c93e470
authored
Jun 04, 2019
by
Winnie Hellmann
Committed by
Clement Ho
Jun 04, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Extract setIssueDetail() into issue boards store
parent
f4cb5d2b
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
18 additions
and
3 deletions
+18
-3
app/assets/javascripts/boards/components/board_new_issue.vue
app/assets/javascripts/boards/components/board_new_issue.vue
+1
-1
app/assets/javascripts/boards/index.js
app/assets/javascripts/boards/index.js
+1
-1
app/assets/javascripts/boards/stores/boards_store.js
app/assets/javascripts/boards/stores/boards_store.js
+5
-1
spec/javascripts/boards/boards_store_spec.js
spec/javascripts/boards/boards_store_spec.js
+11
-0
No files found.
app/assets/javascripts/boards/components/board_new_issue.vue
View file @
0c93e470
...
...
@@ -72,7 +72,7 @@ export default {
// Need this because our jQuery very kindly disables buttons on ALL form submissions
$
(
this
.
$refs
.
submitButton
).
enable
();
boardsStore
.
detail
.
issue
=
issue
;
boardsStore
.
setIssueDetail
(
issue
)
;
boardsStore
.
detail
.
list
=
this
.
list
;
})
.
catch
(()
=>
{
...
...
app/assets/javascripts/boards/index.js
View file @
0c93e470
...
...
@@ -168,7 +168,7 @@ export default () => {
});
}
boardsStore
.
detail
.
issue
=
newIssue
;
boardsStore
.
setIssueDetail
(
newIssue
)
;
},
clearDetailIssue
()
{
boardsStore
.
clearDetailIssue
();
...
...
app/assets/javascripts/boards/stores/boards_store.js
View file @
0c93e470
...
...
@@ -212,7 +212,11 @@ const boardsStore = {
},
clearDetailIssue
()
{
this
.
detail
.
issue
=
{};
this
.
setIssueDetail
({});
},
setIssueDetail
(
issueDetail
)
{
this
.
detail
.
issue
=
issueDetail
;
},
};
...
...
spec/javascripts/boards/boards_store_spec.js
View file @
0c93e470
...
...
@@ -322,6 +322,17 @@ describe('Store', () => {
});
});
describe
(
'
setIssueDetail
'
,
()
=>
{
it
(
'
sets issue details
'
,
()
=>
{
boardsStore
.
detail
.
issue
=
'
some details
'
;
const
dummyValue
=
'
new details
'
;
boardsStore
.
setIssueDetail
(
dummyValue
);
expect
(
boardsStore
.
detail
.
issue
).
toEqual
(
dummyValue
);
});
});
describe
(
'
startMoving
'
,
()
=>
{
it
(
'
stores list and issue
'
,
()
=>
{
const
dummyIssue
=
'
some issue
'
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment