Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0cc1311f
Commit
0cc1311f
authored
Dec 04, 2021
by
Siddharth Asthana
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Gitlab/DelegatePredicateMethods offenses
Changelog: other EE: true
parent
4a0ca8f0
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
3 deletions
+13
-3
.rubocop_todo/gitlab/delegate_predicate_methods.yml
.rubocop_todo/gitlab/delegate_predicate_methods.yml
+0
-1
ee/app/models/ee/group.rb
ee/app/models/ee/group.rb
+13
-2
No files found.
.rubocop_todo/gitlab/delegate_predicate_methods.yml
View file @
0cc1311f
...
...
@@ -9,7 +9,6 @@ Gitlab/DelegatePredicateMethods:
-
app/models/concerns/resolvable_discussion.rb
-
app/models/project.rb
-
ee/app/models/concerns/ee/ci/metadatable.rb
-
ee/app/models/ee/group.rb
-
ee/app/models/ee/namespace.rb
-
ee/app/models/license.rb
-
lib/gitlab/ci/trace/stream.rb
ee/app/models/ee/group.rb
View file @
0cc1311f
...
...
@@ -56,8 +56,7 @@ module EE
has_one
:deletion_schedule
,
class_name:
'GroupDeletionSchedule'
delegate
:deleting_user
,
:marked_for_deletion_on
,
to: :deletion_schedule
,
allow_nil:
true
delegate
:enforced_group_managed_accounts?
,
:enforced_sso?
,
to: :saml_provider
,
allow_nil:
true
delegate
:repository_read_only
,
:repository_read_only?
,
to: :namespace_settings
,
allow_nil:
true
delegate
:repository_read_only
,
to: :namespace_settings
,
allow_nil:
true
has_one
:group_wiki_repository
has_many
:repository_storage_moves
,
class_name:
'Groups::RepositoryStorageMove'
,
inverse_of: :container
...
...
@@ -163,6 +162,18 @@ module EE
group
.
save
end
end
def
enforced_group_managed_accounts?
!!
saml_provider
&
.
enforced_group_managed_accounts?
end
def
enforced_sso?
!!
saml_provider
&
.
enforced_sso?
end
def
repository_read_only?
!!
namespace_settings
&
.
repository_read_only?
end
end
class_methods
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment