Commit 0d1433bd authored by Arturo Herrero's avatar Arturo Herrero

Reduce database manipulation in service spec

I've used used Factory Doctor to reduce un-necessary database
manipulation in the spec.
parent 9e480ebb
...@@ -138,16 +138,16 @@ RSpec.describe Service do ...@@ -138,16 +138,16 @@ RSpec.describe Service do
describe '#can_test?' do describe '#can_test?' do
subject { service.can_test? } subject { service.can_test? }
let(:service) { create(:service, project: project) } let(:service) { build(:service, project: project) }
context 'when repository is not empty' do context 'when repository is not empty' do
let(:project) { create(:project, :repository) } let(:project) { build(:project, :repository) }
it { is_expected.to be true } it { is_expected.to be true }
end end
context 'when repository is empty' do context 'when repository is empty' do
let(:project) { create(:project) } let(:project) { build(:project) }
it { is_expected.to be true } it { is_expected.to be true }
end end
...@@ -165,10 +165,10 @@ RSpec.describe Service do ...@@ -165,10 +165,10 @@ RSpec.describe Service do
describe '#test' do describe '#test' do
let(:data) { 'test' } let(:data) { 'test' }
let(:service) { create(:service, project: project) } let(:service) { build(:service, project: project) }
context 'when repository is not empty' do context 'when repository is not empty' do
let(:project) { create(:project, :repository) } let(:project) { build(:project, :repository) }
it 'test runs execute' do it 'test runs execute' do
expect(service).to receive(:execute).with(data) expect(service).to receive(:execute).with(data)
...@@ -178,7 +178,7 @@ RSpec.describe Service do ...@@ -178,7 +178,7 @@ RSpec.describe Service do
end end
context 'when repository is empty' do context 'when repository is empty' do
let(:project) { create(:project) } let(:project) { build(:project) }
it 'test runs execute' do it 'test runs execute' do
expect(service).to receive(:execute).with(data) expect(service).to receive(:execute).with(data)
...@@ -622,8 +622,8 @@ RSpec.describe Service do ...@@ -622,8 +622,8 @@ RSpec.describe Service do
end end
context 'logging' do context 'logging' do
let(:project) { create(:project) } let(:project) { build(:project) }
let(:service) { create(:service, project: project) } let(:service) { build(:service, project: project) }
let(:test_message) { "test message" } let(:test_message) { "test message" }
let(:arguments) do let(:arguments) do
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment