Add comment about why worker cannot be idempotent

0dfa3514 · Luke Duncalfe · c9ce2122 · 0dfa3514
Commit 0dfa3514 authored Apr 30, 2021 by Luke Duncalfe
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

app/workers/web_hook_worker.rb app/workers/web_hook_worker.rb +4 -1

No files found.
--- a/app/workers/web_hook_worker.rb
+++ b/app/workers/web_hook_worker.rb
 # frozen_string_literal: true

-class WebHookWorker # rubocop:disable Scalability/IdempotentWorker
+# Worker cannot be idempotent: https://gitlab.com/gitlab-org/gitlab/-/issues/218559
+# rubocop:disable Scalability/IdempotentWorker
+class WebHookWorker
  include ApplicationWorker

  feature_category :integrations
@@ -16,3 +18,4 @@ class WebHookWorker # rubocop:disable Scalability/IdempotentWorker
    WebHookService.new(hook, data, hook_name).execute
  end
 end
+# rubocop:enable Scalability/IdempotentWorker