Merge branch '232654-refactor-logging-for-project-missing-project_feature' into 'master'

Use Gitlab::ErrorTracking track & raise vs. logger

See merge request gitlab-org/gitlab!39979

ee/changelogs/unreleased/232654-refactor-logging-for-project-missing-project_feature.yml

+---
+title: Use Gitlab::ErrorTracking in place of project.logger for indexing errors
+merge_request: 39979
+author:
+type: fixed

ee/lib/elastic/latest/project_instance_proxy.rb

@@ -44,9 +44,8 @@ module Elastic
         # When this happens, log the errors to help with debugging, and raise the error to prevent indexing bad data
         TRACKED_FEATURE_SETTINGS.each do |feature|
           data[feature] = target.project_feature.public_send(feature) # rubocop:disable GitlabSecurity/PublicSend
-        rescue NoMethodError => err
-          target.logger.error("Elasticsearch failed to read feature #{feature} for #{target.class} #{target.id}: #{err}")
-          raise
+        rescue NoMethodError => e
+          Gitlab::ErrorTracking.track_and_raise_exception(e, project_id: target.id, feature: feature)
         end
 
         data

ee/spec/lib/elastic/latest/project_instance_proxy_spec.rb

@@ -33,7 +33,10 @@ RSpec.describe Elastic::Latest::ProjectInstanceProxy do
     it 'raises an error for a project with an empty project_feature' do
       allow(project).to receive(:project_feature).and_return(nil)
 
-      expect(project.logger).to receive(:error)
+      expect(Gitlab::ErrorTracking).to receive(:track_and_raise_exception).with(
+        NoMethodError,
+        project_id: project.id,
+        feature: 'issues_access_level').and_call_original
       expect { subject.as_indexed_json }.to raise_error NoMethodError
     end
   end