Merge branch 'project-level-mr-analytics' into 'master'

Project level Merge Request analytics

See merge request gitlab-org/gitlab!38139

ee/app/controllers/projects/analytics/merge_request_analytics_controller.rb

+# frozen_string_literal: true
+
+class Projects::Analytics::MergeRequestAnalyticsController < Projects::ApplicationController
+  before_action :authorize_read_project_merge_request_analytics!
+
+  def show
+  end
+end

ee/app/helpers/ee/analytics/navbar_helper.rb

@@ -10,7 +10,8 @@ module EE
         super + [
           insights_navbar_link(project, current_user),
           code_review_analytics_navbar_link(project, current_user),
-          project_issues_analytics_navbar_link(project, current_user)
+          project_issues_analytics_navbar_link(project, current_user),
+          project_merge_request_analytics_navbar_link(project, current_user)
         ].compact
       end
 
@@ -39,6 +40,17 @@ module EE
         )
       end
 
+      def project_merge_request_analytics_navbar_link(project, current_user)
+        return unless project_nav_tab?(:merge_request_analytics)
+        return unless ::Gitlab::Analytics.project_merge_request_analytics_enabled?
+
+        navbar_sub_item(
+          title: _('Merge Request'),
+          path: 'projects/analytics/merge_requests_analytics#show',
+          link: project_analytics_merge_request_analytics_path(project)
+        )
+      end
+
       def group_merge_request_analytics_navbar_link(group, current_user)
         return unless group_sidebar_link?(:merge_request_analytics)
 

ee/app/helpers/ee/projects_helper.rb

@@ -35,6 +35,10 @@ module EE
         nav_tabs << :code_review
       end
 
+      if can?(current_user, :read_project_merge_request_analytics, project)
+        nav_tabs << :merge_request_analytics
+      end
+
       if can?(current_user, :read_feature_flag, project) && !nav_tabs.include?(:operations)
         nav_tabs << :operations
       end

ee/app/models/license.rb

@@ -30,6 +30,7 @@ class License < ApplicationRecord
     multiple_issue_assignees
     multiple_ldap_servers
     multiple_merge_request_assignees
+    project_merge_request_analytics
     protected_refs_for_users
     push_rules
     related_issues

ee/app/policies/ee/project_policy.rb

@@ -63,6 +63,10 @@ module EE
           @subject.has_regulated_settings?
       end
 
+      condition(:project_merge_request_analytics_available) do
+        @subject.feature_available?(:project_merge_request_analytics)
+      end
+
       condition(:cannot_modify_approvers_rules) do
         regulated_merge_request_approval_settings?
       end
@@ -368,6 +372,9 @@ module EE
 
       rule { can?(:read_merge_request) & code_review_analytics_enabled }.enable :read_code_review_analytics
 
+      rule { reporter & project_merge_request_analytics_available }
+        .enable :read_project_merge_request_analytics
+
       rule { can?(:read_project) & requirements_available }.enable :read_requirement
 
       rule { requirements_available & reporter }.policy do

ee/config/routes/project.rb

@@ -89,6 +89,7 @@ constraints(::Constraints::ProjectUrlConstrainer.new) do
         namespace :analytics do
           resources :code_reviews, only: [:index]
           resource :issues_analytics, only: [:show]
+          resource :merge_request_analytics, only: :show, constraints: -> (req) { Gitlab::Analytics.project_merge_request_analytics_enabled? }
         end
 
         resources :approvers, only: :destroy

ee/lib/gitlab/analytics.rb

@@ -7,6 +7,7 @@ module Gitlab
     PRODUCTIVITY_ANALYTICS_FEATURE_FLAG = :productivity_analytics
     GROUP_COVERAGE_REPORTS_FEATURE_FLAG = :group_coverage_reports
     GROUP_MERGE_REQUEST_ANALYTICS_FEATURE_FLAG = :group_merge_request_analytics
+    PROJECT_MERGE_REQUEST_ANALYTICS_FEATURE_FLAG = :project_merge_request_analytics
 
     FEATURE_FLAGS = [
       CYCLE_ANALYTICS_FEATURE_FLAG,
@@ -40,6 +41,10 @@ module Gitlab
       feature_enabled?(GROUP_MERGE_REQUEST_ANALYTICS_FEATURE_FLAG)
     end
 
+    def self.project_merge_request_analytics_enabled?
+      feature_enabled?(PROJECT_MERGE_REQUEST_ANALYTICS_FEATURE_FLAG)
+    end
+
     def self.feature_enabled_by_default?(flag)
       !!FEATURE_FLAG_DEFAULTS[flag]
     end

ee/spec/controllers/projects/analytics/merge_request_analytics_controller_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Projects::Analytics::MergeRequestAnalyticsController do
+  let_it_be(:current_user) { create(:user) }
+  let_it_be(:group) { create(:group) }
+  let_it_be(:project) { create(:project, group: group) }
+  let_it_be(:feature_flag_name) { Gitlab::Analytics::PROJECT_MERGE_REQUEST_ANALYTICS_FEATURE_FLAG }
+  let_it_be(:feature_name) { :project_merge_request_analytics }
+
+  before do
+    sign_in(current_user)
+
+    stub_feature_flags(feature_flag_name => true)
+    stub_licensed_features(feature_name => true)
+  end
+
+  describe 'GET show' do
+    subject { get :show, params: { namespace_id: group, project_id: project } }
+
+    before do
+      group.add_maintainer(current_user)
+    end
+
+    it { is_expected.to be_successful }
+
+    context 'when license is missing' do
+      before do
+        stub_licensed_features(feature_name => false)
+      end
+
+      it { is_expected.to have_gitlab_http_status(:not_found) }
+    end
+
+    context 'when feature flag is off' do
+      before do
+        stub_feature_flags(feature_flag_name => false)
+      end
+
+      it { is_expected.to have_gitlab_http_status(:not_found) }
+    end
+
+    context 'when the user has no access to the group' do
+      before do
+        current_user.project_authorizations.delete_all
+      end
+
+      it { is_expected.to have_gitlab_http_status(:not_found) }
+    end
+  end
+end

spec/support/shared_contexts/navbar_structure_context.rb

@@ -7,6 +7,7 @@ RSpec.shared_context 'project navbar structure' do
       nav_sub_items: [
         _('CI / CD'),
         (_('Code Review') if Gitlab.ee?),
+        (_('Merge Request') if Gitlab.ee?),
         _('Repository'),
         _('Value Stream')
       ]