Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1150940c
Commit
1150940c
authored
Nov 05, 2021
by
Mark Nuzzo
Committed by
Marcel Amirault
Nov 05, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Include static analysis tests in Definition of Done criteria
parent
4463591b
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
18 additions
and
0 deletions
+18
-0
doc/development/contributing/merge_request_workflow.md
doc/development/contributing/merge_request_workflow.md
+18
-0
No files found.
doc/development/contributing/merge_request_workflow.md
View file @
1150940c
...
@@ -83,6 +83,24 @@ request is as follows:
...
@@ -83,6 +83,24 @@ request is as follows:
migrations on a fresh database before the MR is reviewed. If the review leads
migrations on a fresh database before the MR is reviewed. If the review leads
to large changes in the MR, execute the migrations again once the review is complete.
to large changes in the MR, execute the migrations again once the review is complete.
1.
Write tests for more complex migrations.
1.
Write tests for more complex migrations.
1.
If your merge request adds new validations to existing models, to make sure the
data processing is backwards compatible:
-
Ask in the
[
`#database`
](
https://gitlab.slack.com/archives/CNZ8E900G
)
Slack channel
for assistance to execute the database query that checks the existing rows to
ensure existing rows aren't impacted by the change.
-
Add the necessary validation with a feature flag to be gradually rolled out
following
[
the rollout steps
](
https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#rollout
)
.
If this merge request is urgent, the code owners should make the final call on
whether reviewing existing rows should be included as an immediate follow-up task
to the merge request.
NOTE:
There isn't a way to know anything about our customers' data on their
[
self-managed instances
](
../../subscriptions/self_managed/index.md
)
, so keep
that in mind for any data implications with your merge request.
1.
Merge requests
**must**
adhere to the
[
merge request performance guidelines
](
../merge_request_performance_guidelines.md
)
.
1.
Merge requests
**must**
adhere to the
[
merge request performance guidelines
](
../merge_request_performance_guidelines.md
)
.
1.
For tests that use Capybara, read
1.
For tests that use Capybara, read
[
how to write reliable, asynchronous integration tests
](
https://thoughtbot.com/blog/write-reliable-asynchronous-integration-tests-with-capybara
)
.
[
how to write reliable, asynchronous integration tests
](
https://thoughtbot.com/blog/write-reliable-asynchronous-integration-tests-with-capybara
)
.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment