Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
11bcc1b1
Commit
11bcc1b1
authored
Sep 16, 2020
by
Amelia Bauerly
Committed by
Ezekiel Kigbo
Sep 16, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replacing shared tooltip on confidential sidebar component
parent
c003833d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
27 deletions
+7
-27
app/assets/javascripts/sidebar/components/confidential/confidential_issue_sidebar.vue
...ar/components/confidential/confidential_issue_sidebar.vue
+3
-7
spec/frontend/sidebar/__snapshots__/confidential_issue_sidebar_spec.js.snap
...bar/__snapshots__/confidential_issue_sidebar_spec.js.snap
+4
-20
No files found.
app/assets/javascripts/sidebar/components/confidential/confidential_issue_sidebar.vue
View file @
11bcc1b1
<
script
>
<
script
>
import
{
mapState
}
from
'
vuex
'
;
import
{
mapState
}
from
'
vuex
'
;
import
{
GlIcon
}
from
'
@gitlab/ui
'
;
import
{
GlIcon
,
GlTooltipDirective
}
from
'
@gitlab/ui
'
;
import
{
__
,
sprintf
}
from
'
~/locale
'
;
import
{
__
,
sprintf
}
from
'
~/locale
'
;
import
tooltip
from
'
~/vue_shared/directives/tooltip
'
;
import
eventHub
from
'
~/sidebar/event_hub
'
;
import
eventHub
from
'
~/sidebar/event_hub
'
;
import
EditForm
from
'
./edit_form.vue
'
;
import
EditForm
from
'
./edit_form.vue
'
;
...
@@ -12,7 +11,7 @@ export default {
...
@@ -12,7 +11,7 @@ export default {
GlIcon
,
GlIcon
,
},
},
directives
:
{
directives
:
{
tooltip
,
GlTooltip
:
GlTooltipDirective
,
},
},
props
:
{
props
:
{
fullPath
:
{
fullPath
:
{
...
@@ -73,12 +72,9 @@ export default {
...
@@ -73,12 +72,9 @@ export default {
<div
class=
"block issuable-sidebar-item confidentiality"
>
<div
class=
"block issuable-sidebar-item confidentiality"
>
<div
<div
ref=
"collapseIcon"
ref=
"collapseIcon"
v-
tooltip
v-
gl-tooltip
.
viewport
.
left
:title=
"tooltipLabel"
:title=
"tooltipLabel"
class=
"sidebar-collapsed-icon"
class=
"sidebar-collapsed-icon"
data-container=
"body"
data-placement=
"left"
data-boundary=
"viewport"
@
click=
"toggleForm"
@
click=
"toggleForm"
>
>
<gl-icon
:name=
"confidentialityIcon"
aria-hidden=
"true"
/>
<gl-icon
:name=
"confidentialityIcon"
aria-hidden=
"true"
/>
...
...
spec/frontend/sidebar/__snapshots__/confidential_issue_sidebar_spec.js.snap
View file @
11bcc1b1
...
@@ -7,11 +7,7 @@ exports[`Confidential Issue Sidebar Block renders for confidential = false and i
...
@@ -7,11 +7,7 @@ exports[`Confidential Issue Sidebar Block renders for confidential = false and i
>
>
<div
<div
class="sidebar-collapsed-icon"
class="sidebar-collapsed-icon"
data-boundary="viewport"
title="Not confidential"
data-container="body"
data-original-title="Not confidential"
data-placement="left"
title=""
>
>
<gl-icon-stub
<gl-icon-stub
aria-hidden="true"
aria-hidden="true"
...
@@ -59,11 +55,7 @@ exports[`Confidential Issue Sidebar Block renders for confidential = false and i
...
@@ -59,11 +55,7 @@ exports[`Confidential Issue Sidebar Block renders for confidential = false and i
>
>
<div
<div
class="sidebar-collapsed-icon"
class="sidebar-collapsed-icon"
data-boundary="viewport"
title="Not confidential"
data-container="body"
data-original-title="Not confidential"
data-placement="left"
title=""
>
>
<gl-icon-stub
<gl-icon-stub
aria-hidden="true"
aria-hidden="true"
...
@@ -119,11 +111,7 @@ exports[`Confidential Issue Sidebar Block renders for confidential = true and is
...
@@ -119,11 +111,7 @@ exports[`Confidential Issue Sidebar Block renders for confidential = true and is
>
>
<div
<div
class="sidebar-collapsed-icon"
class="sidebar-collapsed-icon"
data-boundary="viewport"
title="Confidential"
data-container="body"
data-original-title="Confidential"
data-placement="left"
title=""
>
>
<gl-icon-stub
<gl-icon-stub
aria-hidden="true"
aria-hidden="true"
...
@@ -170,11 +158,7 @@ exports[`Confidential Issue Sidebar Block renders for confidential = true and is
...
@@ -170,11 +158,7 @@ exports[`Confidential Issue Sidebar Block renders for confidential = true and is
>
>
<div
<div
class="sidebar-collapsed-icon"
class="sidebar-collapsed-icon"
data-boundary="viewport"
title="Confidential"
data-container="body"
data-original-title="Confidential"
data-placement="left"
title=""
>
>
<gl-icon-stub
<gl-icon-stub
aria-hidden="true"
aria-hidden="true"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment