Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
12a33df9
Commit
12a33df9
authored
May 12, 2021
by
Nicolò Maria Mezzopera
Committed by
Olena Horal-Koretska
May 12, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Hide commit msg for package files without pipeline
parent
2e4b79ad
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
17 additions
and
0 deletions
+17
-0
app/assets/javascripts/packages/details/components/package_files.vue
...javascripts/packages/details/components/package_files.vue
+1
-0
changelogs/unreleased/330396-package-registry-pypi-packages-file-list-vanishes-when-different-c.yml
...try-pypi-packages-file-list-vanishes-when-different-c.yml
+5
-0
spec/frontend/packages/details/components/package_files_spec.js
...rontend/packages/details/components/package_files_spec.js
+11
-0
No files found.
app/assets/javascripts/packages/details/components/package_files.vue
View file @
12a33df9
...
@@ -92,6 +92,7 @@ export default {
...
@@ -92,6 +92,7 @@ export default {
<
template
#cell(commit)=
"{ item }"
>
<
template
#cell(commit)=
"{ item }"
>
<gl-link
<gl-link
v-if=
"item.pipeline && item.pipeline.project"
:href=
"item.pipeline.project.commit_url"
:href=
"item.pipeline.project.commit_url"
class=
"gl-text-gray-500"
class=
"gl-text-gray-500"
data-testid=
"commit-link"
data-testid=
"commit-link"
...
...
changelogs/unreleased/330396-package-registry-pypi-packages-file-list-vanishes-when-different-c.yml
0 → 100644
View file @
12a33df9
---
title
:
Hide commit msg for package files without pipeline
merge_request
:
61571
author
:
type
:
fixed
spec/frontend/packages/details/components/package_files_spec.js
View file @
12a33df9
...
@@ -11,8 +11,10 @@ describe('Package Files', () => {
...
@@ -11,8 +11,10 @@ describe('Package Files', () => {
const
findAllRows
=
()
=>
wrapper
.
findAll
(
'
[data-testid="file-row"
'
);
const
findAllRows
=
()
=>
wrapper
.
findAll
(
'
[data-testid="file-row"
'
);
const
findFirstRow
=
()
=>
findAllRows
().
at
(
0
);
const
findFirstRow
=
()
=>
findAllRows
().
at
(
0
);
const
findSecondRow
=
()
=>
findAllRows
().
at
(
1
);
const
findFirstRowDownloadLink
=
()
=>
findFirstRow
().
find
(
'
[data-testid="download-link"
'
);
const
findFirstRowDownloadLink
=
()
=>
findFirstRow
().
find
(
'
[data-testid="download-link"
'
);
const
findFirstRowCommitLink
=
()
=>
findFirstRow
().
find
(
'
[data-testid="commit-link"
'
);
const
findFirstRowCommitLink
=
()
=>
findFirstRow
().
find
(
'
[data-testid="commit-link"
'
);
const
findSecondRowCommitLink
=
()
=>
findSecondRow
().
find
(
'
[data-testid="commit-link"
'
);
const
findFirstRowFileIcon
=
()
=>
findFirstRow
().
find
(
FileIcon
);
const
findFirstRowFileIcon
=
()
=>
findFirstRow
().
find
(
FileIcon
);
const
findFirstRowCreatedAt
=
()
=>
findFirstRow
().
find
(
TimeAgoTooltip
);
const
findFirstRowCreatedAt
=
()
=>
findFirstRow
().
find
(
TimeAgoTooltip
);
...
@@ -126,5 +128,14 @@ describe('Package Files', () => {
...
@@ -126,5 +128,14 @@ describe('Package Files', () => {
expect
(
findFirstRowCommitLink
().
exists
()).
toBe
(
false
);
expect
(
findFirstRowCommitLink
().
exists
()).
toBe
(
false
);
});
});
});
});
describe
(
'
when only one file lacks an associated pipeline
'
,
()
=>
{
it
(
'
renders the commit when it exists and not otherwise
'
,
()
=>
{
createComponent
([
npmFiles
[
0
],
mavenFiles
[
0
]]);
expect
(
findFirstRowCommitLink
().
exists
()).
toBe
(
true
);
expect
(
findSecondRowCommitLink
().
exists
()).
toBe
(
false
);
});
});
});
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment