fix specs, fix small bug in details

ee/app/services/ee/audit_event_service.rb

@@ -97,7 +97,6 @@ module EE
     def unauth_security_event
       return unless audit_events_enabled?
 
-
       @details.delete(:ip_address) unless admin_audit_log_enabled?
       @details[:entity_path] = @entity&.full_path
 
@@ -127,33 +126,33 @@ module EE
       custom_message = @details[:custom_message]
 
       @details =
-          case action
-          when :destroy
-            {
-                remove: model,
-                author_name: @author.name,
-                target_id: key_title,
-                target_type: model_class,
-                target_details: key_title
-            }
-          when :create
-            {
-                add: model,
-                author_name: @author.name,
-                target_id: key_title,
-                target_type: model_class,
-                target_details: key_title
-            }
-          when :custom
-            {
-                custom_message: custom_message,
-                author_name: @author&.name,
-                target_id: key_title,
-                target_type: model_class,
-                target_details: key_title,
-                ip_address: @details[:ip_address]
-            }
-          end
+        case action
+        when :destroy
+          {
+              remove: model,
+              author_name: @author.name,
+              target_id: key_title,
+              target_type: model_class,
+              target_details: key_title
+          }
+        when :create
+          {
+              add: model,
+              author_name: @author.name,
+              target_id: key_title,
+              target_type: model_class,
+              target_details: key_title
+          }
+        when :custom
+          {
+              custom_message: custom_message,
+              author_name: @author&.name,
+              target_id: key_title,
+              target_type: model_class,
+              target_details: key_title,
+              ip_address: @details[:ip_address]
+          }
+        end
 
       self
     end

lib/audit/details.rb

@@ -31,8 +31,8 @@ module Audit
         "Removed #{value}"
       when :failed_login
         "Failed to login with #{Gitlab::OAuth::Provider.label_for(value).upcase} authentication"
-        when :custom
-          value
+      when :custom_message
+        value
       else
         text_for_change(value)
       end

spec/requests/api/users_spec.rb

@@ -489,14 +489,6 @@ describe API::Users do
       expect(user.reload.organization).to eq('GitLab')
     end
 
-    it 'updates user with a new email' do
-      put api("/users/#{user.id}", admin), email: 'new@email.com'
-
-      expect(response).to have_http_status(200)
-      expect(user.reload.notification_email).to eq('new@email.com')
-      expect(AuditEvent.count).to eq(1)
-    end
-
     it 'updates user with avatar' do
       put api("/users/#{user.id}", admin), { avatar: fixture_file_upload(Rails.root + 'spec/fixtures/banana_sample.gif', 'image/gif') }