Memoize using defined? instead ||= operator

141459b9 · Oswaldo Ferreira · 096b2c53 · 141459b9
Commit 141459b9 authored May 30, 2017 by Oswaldo Ferreira
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

app/services/issue_links/list_service.rb app/services/issue_links/list_service.rb +3 -1

No files found.
--- a/app/services/issue_links/list_service.rb
+++ b/app/services/issue_links/list_service.rb
@@ -46,7 +46,9 @@ module IssueLinks
    end

    def can_destroy_issue_link_on_current_project?
-      @can_destroy_on_current_project ||= can_destroy_issue_link?(@project)
+      return @can_destroy_on_current_project if defined?(@can_destroy_on_current_project)
+
+      @can_destroy_on_current_project = can_destroy_issue_link?(@project)
    end

    def can_destroy_issue_link?(project)