Commit 144239dd authored by pburdette's avatar pburdette

Apply reviewer feedback

Change finder method used
and move colon into bold tag.
parent 06b2e76d
......@@ -36,8 +36,7 @@ export default {
<template>
<p class="gl-display-flex gl-justify-content-space-between gl-mb-2">
<span v-if="hasTitle"
><b>{{ title }}</b
>: {{ value }}</span
><b>{{ title }}:</b> {{ value }}</span
>
<gl-link v-if="hasHelpURL" :href="helpUrl" target="_blank" rel="noopener noreferrer nofollow">
<gl-icon name="question-o" />
......
......@@ -9,7 +9,7 @@ describe('Sidebar detail row', () => {
const value = 'this is the value';
const helpUrl = '/help/ci/runners/README.html';
const findHelpLink = () => wrapper.find(GlLink);
const findHelpLink = () => wrapper.findComponent(GlLink);
const createComponent = (props) => {
wrapper = shallowMount(SidebarDetailRow, {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment