Merge branch 'dz-error-tracking-refactor-factories' into 'master'

Refactor error tracking factories

See merge request gitlab-org/gitlab!67446

spec/controllers/projects/error_tracking/stack_traces_controller_spec.rb

@@ -40,7 +40,7 @@ RSpec.describe Projects::ErrorTracking::StackTracesController do
 
     context 'service result is successful' do
       let(:service_response) { { status: :success, latest_event: error_event } }
-      let(:error_event) { build(:error_tracking_error_event) }
+      let(:error_event) { build(:error_tracking_sentry_error_event) }
 
       it 'responds with success' do
         expect(response).to have_gitlab_http_status(:ok)

spec/controllers/projects/error_tracking_controller_spec.rb

@@ -95,7 +95,7 @@ RSpec.describe Projects::ErrorTrackingController do
             get :index, params: params
           end
 
-          let(:error) { build(:error_tracking_error) }
+          let(:error) { build(:error_tracking_sentry_error) }
 
           it 'returns a list of errors' do
             expect(response).to have_gitlab_http_status(:ok)
@@ -126,7 +126,7 @@ RSpec.describe Projects::ErrorTrackingController do
               .and_return(external_url)
           end
 
-          let(:error) { build(:error_tracking_error) }
+          let(:error) { build(:error_tracking_sentry_error) }
 
           it 'returns a list of errors' do
             get :index, params: project_params(format: :json)
@@ -221,7 +221,7 @@ RSpec.describe Projects::ErrorTrackingController do
           get :details, params: issue_params(issue_id: issue_id, format: :json)
         end
 
-        let(:error) { build(:detailed_error_tracking_error) }
+        let(:error) { build(:error_tracking_sentry_detailed_error) }
 
         it 'returns an error' do
           expected_error = error.as_json.except('first_release_version').merge(

spec/factories/error_tracking/detailed_error.rb

 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :detailed_error_tracking_error, parent: :error_tracking_error, class: 'Gitlab::ErrorTracking::DetailedError' do
+  factory :error_tracking_sentry_detailed_error, parent: :error_tracking_sentry_error, class: 'Gitlab::ErrorTracking::DetailedError' do
     gitlab_issue { 'http://gitlab.example.com/issues/1' }
     external_base_url { 'http://example.com' }
     first_release_last_commit { '68c914da9' }

spec/factories/error_tracking/error.rb

 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :error_tracking_error, class: 'Gitlab::ErrorTracking::Error' do
+  # There is an issue to rename this class https://gitlab.com/gitlab-org/gitlab/-/issues/323342.
+  factory :error_tracking_sentry_error, class: 'Gitlab::ErrorTracking::Error' do
     id { '1' }
     title { 'title' }
     type { 'error' }
@@ -25,4 +26,14 @@ FactoryBot.define do
 
     skip_create
   end
+
+  factory :error_tracking_error, class: 'ErrorTracking::Error' do
+    project
+    name { 'ActionView::MissingTemplate' }
+    description { 'Missing template posts/edit' }
+    actor { 'PostsController#edit' }
+    platform { 'ruby' }
+    first_seen_at { Time.now.iso8601 }
+    last_seen_at { Time.now.iso8601 }
+  end
 end

spec/factories/error_tracking/error_event.rb

 # frozen_string_literal: true
 
 FactoryBot.define do
-  factory :error_tracking_error_event, class: 'Gitlab::ErrorTracking::ErrorEvent' do
+  # There is an issue to rename this class https://gitlab.com/gitlab-org/gitlab/-/issues/323342.
+  factory :error_tracking_sentry_error_event, class: 'Gitlab::ErrorTracking::ErrorEvent' do
     issue_id { 'id' }
     date_received { Time.now.iso8601 }
     stack_trace_entries do
@@ -53,4 +54,14 @@ FactoryBot.define do
 
     skip_create
   end
+
+  factory :error_tracking_error_event, class: 'ErrorTracking::ErrorEvent' do
+    error factory: :error_tracking_error
+
+    description { 'ActionView::MissingTemplate' }
+    environment { 'development' }
+    level { 'error' }
+    occurred_at { Time.now.iso8601 }
+    payload { Gitlab::Json.parse(File.read(Rails.root.join('spec/fixtures/', 'error_tracking/parsed_event.json'))) }
+  end
 end

spec/graphql/resolvers/error_tracking/sentry_detailed_error_resolver_spec.rb

@@ -42,7 +42,7 @@ RSpec.describe Resolvers::ErrorTracking::SentryDetailedErrorResolver do
     end
 
     context 'error matched' do
-      let(:detailed_error) { build(:detailed_error_tracking_error) }
+      let(:detailed_error) { build(:error_tracking_sentry_detailed_error) }
 
       before do
         allow(issue_details_service).to receive(:execute)

spec/lib/gitlab/error_tracking/stack_trace_highlight_decorator_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe Gitlab::ErrorTracking::StackTraceHighlightDecorator do
-  let(:error_event) { build(:error_tracking_error_event) }
+  let(:error_event) { build(:error_tracking_sentry_error_event) }
 
   describe '.decorate' do
     subject(:decorate) { described_class.decorate(error_event) }

spec/models/error_tracking/project_error_tracking_setting_spec.rb

@@ -241,7 +241,7 @@ RSpec.describe ErrorTracking::ProjectErrorTrackingSetting do
   end
 
   describe '#issue_details' do
-    let(:issue) { build(:detailed_error_tracking_error) }
+    let(:issue) { build(:error_tracking_sentry_detailed_error) }
     let(:sentry_client) { double('sentry_client', issue_details: issue) }
     let(:commit_id) { issue.first_release_version }
 

spec/presenters/sentry_error_presenter_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 RSpec.describe SentryErrorPresenter do
-  let(:error) { build(:detailed_error_tracking_error) }
+  let(:error) { build(:error_tracking_sentry_detailed_error) }
   let(:presenter) { described_class.new(error) }
 
   describe '#frequency' do

spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe 'getting a detailed sentry error' do
   let_it_be(:project) { create(:project, :repository) }
   let_it_be(:project_setting) { create(:project_error_tracking_setting, project: project) }
   let_it_be(:current_user) { project.owner }
-  let_it_be(:sentry_detailed_error) { build(:detailed_error_tracking_error) }
+  let_it_be(:sentry_detailed_error) { build(:error_tracking_sentry_detailed_error) }
 
   let(:sentry_gid) { sentry_detailed_error.to_global_id.to_s }
   let(:fields) do

spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb

@@ -16,7 +16,7 @@ RSpec.describe 'sentry errors requests' do
   end
 
   describe 'getting a detailed sentry error' do
-    let_it_be(:sentry_detailed_error) { build(:detailed_error_tracking_error) }
+    let_it_be(:sentry_detailed_error) { build(:error_tracking_sentry_detailed_error) }
 
     let(:sentry_gid) { sentry_detailed_error.to_global_id.to_s }
 
@@ -97,7 +97,7 @@ RSpec.describe 'sentry errors requests' do
   end
 
   describe 'getting an errors list' do
-    let_it_be(:sentry_error) { build(:error_tracking_error) }
+    let_it_be(:sentry_error) { build(:error_tracking_sentry_error) }
     let_it_be(:pagination) do
       {
         'next' => { 'cursor' => '2222' },
@@ -193,7 +193,7 @@ RSpec.describe 'sentry errors requests' do
   end
 
   describe 'getting a stack trace' do
-    let_it_be(:sentry_stack_trace) { build(:error_tracking_error_event) }
+    let_it_be(:sentry_stack_trace) { build(:error_tracking_sentry_error_event) }
 
     let(:sentry_gid) { global_id_of(Gitlab::ErrorTracking::DetailedError.new(id: 1)) }
 

spec/services/error_tracking/issue_details_service_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe ErrorTracking::IssueDetailsService do
   describe '#execute' do
     context 'with authorized user' do
       context 'when issue_details returns a detailed error' do
-        let(:detailed_error) { build(:detailed_error_tracking_error) }
+        let(:detailed_error) { build(:error_tracking_sentry_detailed_error) }
         let(:params) { { issue_id: detailed_error.id } }
 
         before do

spec/services/error_tracking/issue_latest_event_service_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe ErrorTracking::IssueLatestEventService do
   describe '#execute' do
     context 'with authorized user' do
       context 'when issue_latest_event returns an error event' do
-        let(:error_event) { build(:error_tracking_error_event) }
+        let(:error_event) { build(:error_tracking_sentry_error_event) }
 
         before do
           expect(error_tracking_setting)