Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
151725fe
Commit
151725fe
authored
May 17, 2021
by
Alexander Turinske
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clean up threat monitoring alerts code
- remove unnecessary testing waits - rename variable to be more readable
parent
7ebd83cc
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
5 deletions
+3
-5
app/assets/javascripts/vue_shared/alert_details/components/sidebar/sidebar_status.vue
...hared/alert_details/components/sidebar/sidebar_status.vue
+3
-3
ee/spec/frontend/threat_monitoring/components/alerts/alert_drawer_spec.js
.../threat_monitoring/components/alerts/alert_drawer_spec.js
+0
-1
spec/frontend/vue_shared/alert_details/sidebar/alert_sidebar_status_spec.js
...shared/alert_details/sidebar/alert_sidebar_status_spec.js
+0
-1
No files found.
app/assets/javascripts/vue_shared/alert_details/components/sidebar/sidebar_status.vue
View file @
151725fe
...
...
@@ -62,11 +62,11 @@ export default {
dropdown
.
show
();
}
},
handleUpdating
(
updating
)
{
if
(
!
updating
)
{
handleUpdating
(
isMutationInProgress
)
{
if
(
!
isMutationInProgress
)
{
this
.
$emit
(
'
alert-update
'
);
}
this
.
isUpdating
=
updating
;
this
.
isUpdating
=
isMutationInProgress
;
},
},
};
...
...
ee/spec/frontend/threat_monitoring/components/alerts/alert_drawer_spec.js
View file @
151725fe
...
...
@@ -167,7 +167,6 @@ describe('Alert Drawer', () => {
createWrapper
({
props
:
{
selectedAlert
:
mockAlerts
[
0
]
}
});
expect
(
wrapper
.
emitted
(
'
alert-update
'
)).
toBeUndefined
();
findStatus
().
vm
.
$emit
(
'
alert-update
'
);
await
wrapper
.
vm
.
$nextTick
();
expect
(
wrapper
.
emitted
(
'
alert-update
'
)).
toEqual
([[]]);
});
});
spec/frontend/vue_shared/alert_details/sidebar/alert_sidebar_status_spec.js
View file @
151725fe
...
...
@@ -125,7 +125,6 @@ describe('Alert Details Sidebar Status', () => {
mountComponent
({
sidebarCollapsed
:
false
});
expect
(
wrapper
.
emitted
(
'
alert-update
'
)).
toBeUndefined
();
findAlertStatus
().
vm
.
$emit
(
'
handle-updating
'
);
await
wrapper
.
vm
.
$nextTick
();
expect
(
wrapper
.
emitted
(
'
alert-update
'
)).
toEqual
([[]]);
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment