Merge branch '31571-implement-dag-for-review-review-prepare-qa' into 'master'

Implement DAG for review/review-prepare/qa

See merge request gitlab-org/gitlab!17920

.gitlab/ci/reports.gitlab-ci.yml

@@ -198,6 +198,7 @@ dast:
     - .only-code-qa-changes
     - .only-review
   stage: qa
+  needs: ["review-deploy"]
   dependencies: ["review-deploy"]
   before_script:
     - export DAST_WEBSITE="$(cat review_app_url.txt)"

.gitlab/ci/review.gitlab-ci.yml

@@ -183,6 +183,7 @@ review-cleanup-failed-deployment:
     GITLAB_ADMIN_PASSWORD: "${REVIEW_APPS_ROOT_PASSWORD}"
     GITHUB_ACCESS_TOKEN: "${REVIEW_APPS_QA_GITHUB_ACCESS_TOKEN}"
     EE_LICENSE: "${REVIEW_APPS_EE_LICENSE}"
+  needs: ["review-deploy"]
   dependencies: ["review-deploy"]
   artifacts:
     paths:
@@ -239,6 +240,8 @@ review-performance:
   extends:
     - .review-performance-base
     - .only-review
+  needs: ["review-deploy"]
+  dependencies: ["review-deploy"]
   before_script:
     - export CI_ENVIRONMENT_URL="$(cat review_app_url.txt)"
     - echo "${CI_ENVIRONMENT_URL}"
@@ -259,6 +262,7 @@ schedule:review-performance:
   extends:
     - .review-performance-base
     - .only-review-schedules
+  needs: ["schedule:review-deploy"]
   dependencies: ["schedule:review-deploy"]
 
 parallel-spec-reports:

doc/development/pipelines.md

@@ -185,11 +185,11 @@ subgraph "`qa` stage"
     R --> |needs| F;
     P --> |needs| B;
     P --> |needs| F;
-    review-qa-smoke -.-> |depends on| G;
-    review-qa-all -.-> |depends on| G;
-    review-qa-performance -.-> |depends on| G;
-    X2["schedule:review-performance<br/>(master only)"] -.-> |depends on| G2;
-    dast -.-> |depends on| G;
+    review-qa-smoke -.-> |needs and depends on| G;
+    review-qa-all -.-> |needs and depends on| G;
+    review-performance -.-> |needs and depends on| G;
+    X2["schedule:review-performance<br/>(master only)"] -.-> |needs and depends on| G2;
+    dast -.-> |needs and depends on| G;
     end
 
 subgraph "`notification` stage"