Address review comments

Address reviewer comments on the MR
including replacing utility classes

ee/app/assets/javascripts/analytics/cycle_analytics/components/base.vue

@@ -225,9 +225,9 @@ export default {
         class="gl-align-self-start gl-sm-align-self-start gl-mt-0 gl-sm-mt-5"
       />
     </div>
-    <div class="mw-100">
-      <div class="mt-3 py-2 px-3 bg-gray-light border-top border-bottom">
-        <div v-if="shouldDisplayPathNavigation" class="w-100 pb-2">
+    <div class="gl-max-w-full">
+      <div class="gl-mt-3 gl-py-2 gl-px-3 bg-gray-light border-top border-bottom">
+        <div v-if="shouldDisplayPathNavigation" class="gl-w-full gl-pb-2">
           <path-navigation
             class="js-path-navigation"
             :loading="isLoading"

ee/app/assets/javascripts/analytics/cycle_analytics/store/actions.js

@@ -217,7 +217,7 @@ export const updateStage = ({ dispatch, getters }, { id, ...params }) => {
 
   return Api.cycleAnalyticsUpdateStage(currentGroupPath, currentValueStreamId, id, params)
     .then(({ data }) => dispatch('receiveUpdateStageSuccess', data))
-    .catch(({ response: { status = 400, data: responseData } = {} }) =>
+    .catch(({ response: { status = httpStatus.BAD_REQUEST, data: responseData } = {} }) =>
       dispatch('receiveUpdateStageError', { status, responseData, data: { id, ...params } }),
     );
 };
@@ -289,7 +289,7 @@ export const reorderStage = ({ dispatch, getters }, initialData) => {
 
   return Api.cycleAnalyticsUpdateStage(currentGroupPath, currentValueStreamId, id, params)
     .then(({ data }) => dispatch('receiveReorderStageSuccess', data))
-    .catch(({ response: { status = 400, data: responseData } = {} }) =>
+    .catch(({ response: { status = httpStatus.BAD_REQUEST, data: responseData } = {} }) =>
       dispatch('receiveReorderStageError', { status, responseData }),
     );
 };

ee/spec/frontend/api_spec.js

 import MockAdapter from 'axios-mock-adapter';
 import Api from 'ee/api';
-import * as cycleAnalyticsConstants from 'ee/analytics/cycle_analytics/constants';
+import * as valueStreamAnalyticsConstants from 'ee/analytics/cycle_analytics/constants';
 import axios from '~/lib/utils/axios_utils';
 import httpStatus from '~/lib/utils/http_status';
 import * as analyticsMockData from 'ee_jest/analytics/cycle_analytics/mock_data';
@@ -206,13 +206,15 @@ describe('Api', () => {
     const groupId = 'counting-54321';
     const stageId = 'thursday';
     const valueStreamId = 'a-city-by-the-light-divided';
-    const dummyCycleAnalyticsUrlRoot = `${dummyUrlRoot}/groups/${groupId}/-/analytics/value_stream_analytics`;
+    const dummyValueStreamAnalyticsUrlRoot = `${dummyUrlRoot}/groups/${groupId}/-/analytics/value_stream_analytics`;
     const defaultParams = {
       created_after: createdAfter,
       created_before: createdBefore,
     };
     const valueStreamBaseUrl = ({ resource = '', id = null }) =>
-      [dummyCycleAnalyticsUrlRoot, id ? `value_streams/${id}/${resource}` : resource].join('/');
+      [dummyValueStreamAnalyticsUrlRoot, id ? `value_streams/${id}/${resource}` : resource].join(
+        '/',
+      );
 
     const expectRequestWithCorrectParameters = (responseObj, { params, expectedUrl, response }) => {
       const {
@@ -247,7 +249,7 @@ describe('Api', () => {
         const params = {
           ...defaultParams,
           project_ids: null,
-          subject: cycleAnalyticsConstants.TASKS_BY_TYPE_SUBJECT_ISSUE,
+          subject: valueStreamAnalyticsConstants.TASKS_BY_TYPE_SUBJECT_ISSUE,
           label_ids: labelIds,
         };
         const expectedUrl = analyticsMockData.endpoints.tasksByTypeData;
@@ -270,7 +272,7 @@ describe('Api', () => {
         const params = {
           ...defaultParams,
           project_ids: null,
-          subject: cycleAnalyticsConstants.TASKS_BY_TYPE_SUBJECT_ISSUE,
+          subject: valueStreamAnalyticsConstants.TASKS_BY_TYPE_SUBJECT_ISSUE,
           label_ids: labelIds,
         };
 
@@ -292,7 +294,7 @@ describe('Api', () => {
       it('fetches value stream analytics summary data', done => {
         const response = [{ value: 0, title: 'New Issues' }, { value: 0, title: 'Deploys' }];
         const params = { ...defaultParams };
-        const expectedUrl = `${dummyCycleAnalyticsUrlRoot}/summary`;
+        const expectedUrl = `${dummyValueStreamAnalyticsUrlRoot}/summary`;
         mock.onGet(expectedUrl).reply(httpStatus.OK, response);
 
         Api.cycleAnalyticsSummaryData(groupId, params)
@@ -316,7 +318,7 @@ describe('Api', () => {
         ];
         const params = { ...defaultParams };
 
-        const expectedUrl = `${dummyCycleAnalyticsUrlRoot}/time_summary`;
+        const expectedUrl = `${dummyValueStreamAnalyticsUrlRoot}/time_summary`;
         mock.onGet(expectedUrl).reply(httpStatus.OK, response);
 
         Api.cycleAnalyticsTimeSummaryData(groupId, params)