Merge branch '338059-ci-sources-pipelines-step-3-2-remove-columns' into 'master'

Drop old int4 PK columns for ci_sources_pipelines

See merge request gitlab-org/gitlab!70896

db/post_migrate/20210922025631_drop_int4_column_for_ci_sources_pipelines.rb

+# frozen_string_literal: true
+
+class DropInt4ColumnForCiSourcesPipelines < Gitlab::Database::Migration[1.0]
+  enable_lock_retries!
+
+  def change
+    remove_column :ci_sources_pipelines, :source_job_id_convert_to_bigint, :integer
+  end
+end

db/schema_migrations/20210922025631

+43b02083323765888f019386138e8fbaa3182d74bd5e8790d6fae6ea6f0a2104
\ No newline at end of file

db/structure.sql

@@ -11992,7 +11992,6 @@ CREATE TABLE ci_sources_pipelines (
     project_id integer,
     pipeline_id integer,
     source_project_id integer,
-    source_job_id_convert_to_bigint integer,
     source_pipeline_id integer,
     source_job_id bigint
 );

spec/migrations/20210922025631_drop_int4_column_for_ci_sources_pipelines_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+require_migration!('drop_int4_column_for_ci_sources_pipelines')
+
+RSpec.describe DropInt4ColumnForCiSourcesPipelines do
+  let(:ci_sources_pipelines) { table(:ci_sources_pipelines) }
+
+  it 'correctly migrates up and down' do
+    reversible_migration do |migration|
+      migration.before -> {
+        expect(ci_sources_pipelines.column_names).to include('source_job_id_convert_to_bigint')
+      }
+
+      migration.after -> {
+        ci_sources_pipelines.reset_column_information
+        expect(ci_sources_pipelines.column_names).not_to include('source_job_id_convert_to_bigint')
+      }
+    end
+  end
+end