Merge branch '299489-over-10-of-graphql-descriptions-are-missing-add-key' into 'master'

Add description key to GraphQL values

See merge request gitlab-org/gitlab!61073

.rubocop_manual_todo.yml

@@ -13,15 +13,10 @@
 # WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/322903
 Graphql/Descriptions:
   Exclude:
-    - 'app/graphql/types/container_expiration_policy_cadence_enum.rb'
-    - 'app/graphql/types/container_expiration_policy_keep_enum.rb'
-    - 'app/graphql/types/container_expiration_policy_older_than_enum.rb'
-    - 'app/graphql/types/packages/package_type_enum.rb'
     - 'app/graphql/types/snippets/blob_action_enum.rb'
     - 'app/graphql/types/snippets/type_enum.rb'
     - 'app/graphql/types/snippets/visibility_scopes_enum.rb'
     - 'ee/app/graphql/ee/types/list_limit_metric_enum.rb'
-    - 'ee/app/graphql/types/alert_management/payload_alert_field_name_enum.rb'
     - 'ee/app/graphql/types/epic_state_enum.rb'
     - 'ee/app/graphql/types/health_status_enum.rb'
     - 'ee/app/graphql/types/iteration_state_enum.rb'

app/graphql/types/container_expiration_policy_cadence_enum.rb

@@ -11,7 +11,7 @@ module Types
     }.freeze
 
     ::ContainerExpirationPolicy.cadence_options.each do |option, description|
-      value OPTIONS_MAPPING[option], description, value: option.to_s
+      value OPTIONS_MAPPING[option], description: description, value: option.to_s
     end
   end
 end

app/graphql/types/container_expiration_policy_keep_enum.rb

@@ -12,7 +12,7 @@ module Types
     }.freeze
 
     ::ContainerExpirationPolicy.keep_n_options.each do |option, description|
-      value OPTIONS_MAPPING[option], description, value: option
+      value OPTIONS_MAPPING[option], description: description, value: option
     end
   end
 end

app/graphql/types/container_expiration_policy_older_than_enum.rb

@@ -10,7 +10,7 @@ module Types
     }.freeze
 
     ::ContainerExpirationPolicy.older_than_options.each do |option, description|
-      value OPTIONS_MAPPING[option], description, value: option.to_s
+      value OPTIONS_MAPPING[option], description: description, value: option.to_s
     end
   end
 end

app/graphql/types/packages/package_type_enum.rb

@@ -10,7 +10,7 @@ module Types
 
       ::Packages::Package.package_types.keys.each do |package_type|
         type_name = PACKAGE_TYPE_NAMES.fetch(package_type.to_sym, package_type.capitalize)
-        value package_type.to_s.upcase, "Packages from the #{type_name} package manager", value: package_type.to_s
+        value package_type.to_s.upcase, description: "Packages from the #{type_name} package manager", value: package_type.to_s
       end
     end
   end

ee/app/graphql/types/alert_management/payload_alert_field_name_enum.rb

@@ -7,7 +7,7 @@ module Types
       description 'Values for alert field names used in the custom mapping'
 
       ::Gitlab::AlertManagement.alert_fields.each do |field|
-        value field[:name].upcase, field[:description], value: field[:name]
+        value field[:name].upcase, description: field[:description], value: field[:name]
       end
     end
   end