Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
18774f65
Commit
18774f65
authored
Jan 12, 2017
by
Regis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
make tests pass - change a bit of logic
parent
acc3ec6f
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
6 deletions
+8
-6
app/assets/javascripts/vue_pipelines_index/stage.js.es6
app/assets/javascripts/vue_pipelines_index/stage.js.es6
+8
-6
No files found.
app/assets/javascripts/vue_pipelines_index/stage.js.es6
View file @
18774f65
...
...
@@ -19,7 +19,8 @@
This was preventing turbolinks to make the request to the link clicked
Vue will always look at the VDOM element which is the button
It has a special attribute 'aria-describedby' which will not exist:
It has a special attribute 'aria-expanded':
- which will let us know if it is expanded
- once the build link is clicked
- when someone clicks outside of the dropdown
...
...
@@ -27,12 +28,13 @@
- here we setTimeout to give enough time to initialize the request
- but short enough that a subsequent click will reset that state
*/
if (!e.currentTarget.attributes['aria-describedby']) {
setTimeout(() => {
this.request = false;
}, 100);
return
null
;
const areaExpanded = e.currentTarget.attributes['aria-expanded'];
if (areaExpanded && areaExpanded.textContent) {
return
setTimeout(() => (this.request = false), 100)
;
}
if (this.request) return this.clearBuilds();
return this.$http.get(this.stage.dropdown_path)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment