Remove headPath and basePath

The base pipeline artifact warning was the last thing relying on these
We can render the widget when we have a codequalityReportsPath
and get rid of codeclimate.headPath and codeclimate.basePath altogether

app/assets/javascripts/reports/codequality_report/grouped_codequality_reports_app.vue

@@ -12,19 +12,10 @@ export default {
     ReportSection,
   },
   props: {
-    headPath: {
-      type: String,
-      required: true,
-    },
     headBlobPath: {
       type: String,
       required: true,
     },
-    basePath: {
-      type: String,
-      required: false,
-      default: null,
-    },
     baseBlobPath: {
       type: String,
       required: false,
@@ -52,8 +43,6 @@ export default {
   },
   created() {
     this.setPaths({
-      basePath: this.basePath,
-      headPath: this.headPath,
       baseBlobPath: this.baseBlobPath,
       headBlobPath: this.headBlobPath,
       reportsPath: this.codequalityReportsPath,

app/assets/javascripts/reports/codequality_report/store/mutations.js

@@ -2,8 +2,6 @@ import * as types from './mutation_types';
 
 export default {
   [types.SET_PATHS](state, paths) {
-    state.basePath = paths.basePath;
-    state.headPath = paths.headPath;
     state.baseBlobPath = paths.baseBlobPath;
     state.headBlobPath = paths.headBlobPath;
     state.reportsPath = paths.reportsPath;

app/assets/javascripts/reports/codequality_report/store/state.js

 export default () => ({
-  basePath: null,
-  headPath: null,
   reportsPath: null,
 
   baseBlobPath: null,

app/assets/javascripts/vue_merge_request_widget/mr_widget_options.vue

@@ -150,7 +150,7 @@ export default {
       );
     },
     shouldRenderCodeQuality() {
-      return this.mr?.codeclimate?.head_path;
+      return this.mr?.codequalityReportsPath;
     },
     shouldRenderRelatedLinks() {
       return Boolean(this.mr.relatedLinks) && !this.mr.isNothingToMergeState;
@@ -496,8 +496,6 @@ export default {
       <!-- <extensions-container :mr="mr" /> -->
       <grouped-codequality-reports-app
         v-if="shouldRenderCodeQuality"
-        :base-path="mr.codeclimate.base_path"
-        :head-path="mr.codeclimate.head_path"
         :head-blob-path="mr.headBlobPath"
         :base-blob-path="mr.baseBlobPath"
         :codequality-reports-path="mr.codequalityReportsPath"

app/assets/javascripts/vue_merge_request_widget/stores/mr_widget_store.js

@@ -261,7 +261,6 @@ export default class MergeRequestStore {
     this.baseBlobPath = blobPath.base_path || '';
     this.codequalityReportsPath = data.codequality_reports_path;
     this.codequalityHelpPath = data.codequality_help_path;
-    this.codeclimate = data.codeclimate;
 
     // Security reports
     this.sastComparisonPath = data.sast_comparison_path;

ee/app/assets/javascripts/vue_merge_request_widget/mr_widget_options.vue

@@ -307,8 +307,6 @@ export default {
       <blocking-merge-requests-report :mr="mr" />
       <grouped-codequality-reports-app
         v-if="shouldRenderCodeQuality"
-        :base-path="mr.codeclimate.base_path"
-        :head-path="mr.codeclimate.head_path"
         :head-blob-path="mr.headBlobPath"
         :base-blob-path="mr.baseBlobPath"
         :codequality-reports-path="mr.codequalityReportsPath"

spec/frontend/reports/codequality_report/grouped_codequality_reports_app_spec.js

@@ -14,8 +14,6 @@ describe('Grouped code quality reports app', () => {
 
   const PATHS = {
     codequalityHelpPath: 'codequality_help.html',
-    basePath: 'base.json',
-    headPath: 'head.json',
     baseBlobPath: 'base/blob/path/',
     headBlobPath: 'head/blob/path/',
   };

spec/frontend/reports/codequality_report/store/actions_spec.js

@@ -24,8 +24,6 @@ describe('Codequality Reports actions', () => {
   describe('setPaths', () => {
     it('should commit SET_PATHS mutation', (done) => {
       const paths = {
-        basePath: 'basePath',
-        headPath: 'headPath',
         baseBlobPath: 'baseBlobPath',
         headBlobPath: 'headBlobPath',
         reportsPath: 'reportsPath',
@@ -49,7 +47,6 @@ describe('Codequality Reports actions', () => {
 
     beforeEach(() => {
       localState.reportsPath = endpoint;
-      localState.basePath = '/base/path';
       mock = new MockAdapter(axios);
     });
 

spec/frontend/reports/codequality_report/store/mutations_spec.js

@@ -12,24 +12,18 @@ describe('Codequality Reports mutations', () => {
 
   describe('SET_PATHS', () => {
     it('sets paths to given values', () => {
-      const basePath = 'base.json';
-      const headPath = 'head.json';
       const baseBlobPath = 'base/blob/path/';
       const headBlobPath = 'head/blob/path/';
       const reportsPath = 'reports.json';
       const helpPath = 'help.html';
 
       mutations.SET_PATHS(localState, {
-        basePath,
-        headPath,
         baseBlobPath,
         headBlobPath,
         reportsPath,
         helpPath,
       });
 
-      expect(localState.basePath).toEqual(basePath);
-      expect(localState.headPath).toEqual(headPath);
       expect(localState.baseBlobPath).toEqual(baseBlobPath);
       expect(localState.headBlobPath).toEqual(headBlobPath);
       expect(localState.reportsPath).toEqual(reportsPath);

spec/frontend/vue_mr_widget/mock_data.js

@@ -234,14 +234,11 @@ export default {
     can_revert_on_current_merge_request: true,
     can_cherry_pick_on_current_merge_request: true,
   },
-  codeclimate: {
-    head_path: 'head.json',
-    base_path: 'base.json',
-  },
   blob_path: {
     base_path: 'blob_path',
     head_path: 'blob_path',
   },
+  codequality_reports_path: 'codequality_reports.json',
   codequality_help_path: 'code_quality.html',
   target_branch_path: '/root/acets-app/branches/main',
   source_branch_path: '/root/acets-app/branches/daaaa',