Merge branch '273301-audit-and-update-buttons-on-projects-pipelinescontroller-show' into 'master'

Resolve "Audit and update buttons on Projects::PipelinesController#show"

See merge request gitlab-org/gitlab!84724

app/assets/javascripts/pipelines/components/header_component.vue

@@ -249,8 +249,7 @@ export default {
         :title="$options.BUTTON_TOOLTIP_RETRY"
         :loading="isRetrying"
         :disabled="isRetrying"
-        category="secondary"
-        variant="info"
+        variant="confirm"
         data-testid="retryPipeline"
         class="js-retry-button"
         @click="retryPipeline()"
@@ -262,7 +261,6 @@ export default {
         v-if="canCancelPipeline"
         :loading="isCanceling"
         :disabled="isCanceling"
-        class="gl-ml-3"
         variant="danger"
         data-testid="cancelPipeline"
         @click="cancelPipeline()"

app/assets/javascripts/vue_shared/components/header_ci_component.vue

@@ -117,7 +117,7 @@ export default {
 
 <template>
   <header
-    class="page-content-header gl-display-flex gl-min-h-7"
+    class="page-content-header gl-md-display-flex gl-min-h-7"
     data-qa-selector="pipeline_header"
     data-testid="ci-header-content"
   >
@@ -163,11 +163,7 @@ export default {
       </template>
     </section>
 
-    <section
-      v-if="$slots.default"
-      data-testid="ci-header-action-buttons"
-      class="gl-display-flex gl-mr-3"
-    >
+    <section v-if="$slots.default" data-testid="ci-header-action-buttons" class="gl-display-flex">
       <slot></slot>
     </section>
     <gl-button

app/helpers/button_helper.rb

@@ -20,7 +20,7 @@ module ButtonHelper
   #
   # See http://clipboardjs.com/#usage
   def clipboard_button(data = {})
-    css_class = data[:class] || 'btn-clipboard btn-transparent'
+    css_class = data[:class] || 'btn-clipboard gl-button btn-default-tertiary btn-icon btn-sm'
     title = data[:title] || _('Copy')
     button_text = data[:button_text] || nil
     hide_tooltip = data[:hide_tooltip] || false

spec/helpers/button_helper_spec.rb

@@ -164,7 +164,7 @@ RSpec.describe ButtonHelper do
     context 'with default options' do
       context 'when no `text` attribute is not provided' do
         it 'shows copy to clipboard button with default configuration and no text set to copy' do
-          expect(element.attr('class')).to eq('btn btn-clipboard btn-transparent')
+          expect(element.attr('class')).to eq('btn btn-clipboard gl-button btn-default-tertiary btn-icon btn-sm')
           expect(element.attr('type')).to eq('button')
           expect(element.attr('aria-label')).to eq('Copy')
           expect(element.attr('aria-live')).to eq('polite')