Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1944c395
Commit
1944c395
authored
Jul 10, 2020
by
Ezekiel Kigbo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Minor review comments
parent
1757a445
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
13 deletions
+6
-13
ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_select.vue
...lytics/cycle_analytics/components/value_stream_select.vue
+3
-6
ee/spec/frontend/analytics/cycle_analytics/components/value_stream_select_spec.js
...cs/cycle_analytics/components/value_stream_select_spec.js
+3
-7
No files found.
ee/app/assets/javascripts/analytics/cycle_analytics/components/value_stream_select.vue
View file @
1944c395
...
@@ -11,7 +11,6 @@ export default {
...
@@ -11,7 +11,6 @@ export default {
directives
:
{
directives
:
{
GlModalDirective
,
GlModalDirective
,
},
},
props
:
{},
data
()
{
data
()
{
return
{
return
{
name
:
''
,
name
:
''
,
...
@@ -26,11 +25,9 @@ export default {
...
@@ -26,11 +25,9 @@ export default {
</
script
>
</
script
>
<
template
>
<
template
>
<gl-form>
<gl-form>
<gl-button
<gl-button
v-gl-modal-directive=
"'create-value-stream-modal'"
>
{{
v-gl-modal-directive=
"'create-value-stream-modal'"
__
(
'
Create new value stream
'
)
data-testid=
"create-value-stream"
}}
</gl-button>
>
{{
__
(
'
Create new value stream
'
)
}}
</gl-button
>
<gl-modal
<gl-modal
modal-id=
"create-value-stream-modal"
modal-id=
"create-value-stream-modal"
:title=
"__('Value Stream Name')"
:title=
"__('Value Stream Name')"
...
...
ee/spec/frontend/analytics/cycle_analytics/components/value_stream_select_spec.js
View file @
1944c395
...
@@ -5,12 +5,8 @@ import ValueStreamSelect from 'ee/analytics/cycle_analytics/components/value_str
...
@@ -5,12 +5,8 @@ import ValueStreamSelect from 'ee/analytics/cycle_analytics/components/value_str
describe
(
'
ValueStreamSelect
'
,
()
=>
{
describe
(
'
ValueStreamSelect
'
,
()
=>
{
let
wrapper
=
null
;
let
wrapper
=
null
;
function
createComponent
()
{
const
createComponent
=
()
=>
shallowMount
(
ValueStreamSelect
,
{});
return
shallowMount
(
ValueStreamSelect
,
{});
}
const
findModal
=
()
=>
wrapper
.
find
(
GlModal
);
const
findModal
=
()
=>
wrapper
.
find
(
GlModal
);
const
submitButtonDisabledState
=
()
=>
findModal
().
props
(
'
actionPrimary
'
).
attributes
[
1
].
disabled
;
const
submitButtonDisabledState
=
()
=>
findModal
().
props
(
'
actionPrimary
'
).
attributes
[
1
].
disabled
;
beforeEach
(()
=>
{
beforeEach
(()
=>
{
...
@@ -27,9 +23,9 @@ describe('ValueStreamSelect', () => {
...
@@ -27,9 +23,9 @@ describe('ValueStreamSelect', () => {
});
});
describe
(
'
with valid fields
'
,
()
=>
{
describe
(
'
with valid fields
'
,
()
=>
{
beforeEach
(()
=>
{
beforeEach
(
async
()
=>
{
wrapper
=
createComponent
();
wrapper
=
createComponent
();
wrapper
.
setData
({
name
:
'
Cool stream
'
});
await
wrapper
.
setData
({
name
:
'
Cool stream
'
});
});
});
it
(
'
submit button is enabled
'
,
()
=>
{
it
(
'
submit button is enabled
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment