Merge branch 'gaga5lala/remove-feature-flag' into 'master'

remove attempt_group_search_optimizations feature flag

See merge request gitlab-org/gitlab!40881

app/finders/issuable_finder.rb

@@ -103,8 +103,8 @@ class IssuableFinder
     items = filter_negated_items(items)
 
     # This has to be last as we use a CTE as an optimization fence
-    # for counts by passing the force_cte param and enabling the
-    # attempt_group_search_optimizations feature flag
+    # for counts by passing the force_cte param and passing the
+    # attempt_group_search_optimizations param
     # https://www.postgresql.org/docs/current/static/queries-with.html
     items = by_search(items)
 
@@ -229,8 +229,7 @@ class IssuableFinder
   end
 
   def attempt_group_search_optimizations?
-    params[:attempt_group_search_optimizations] &&
-      Feature.enabled?(:attempt_group_search_optimizations, default_enabled: true)
+    params[:attempt_group_search_optimizations]
   end
 
   def attempt_project_search_optimizations?

changelogs/unreleased/214382-remove-feature-flag.yml

+---
+title: Remove attempt_group_search_optimizations feature flag
+merge_request: 40881
+author: gaga5lala
+type: other

ee/app/finders/epics_finder.rb

@@ -65,8 +65,7 @@ class EpicsFinder < IssuableFinder
     items = filter_negated_items(items)
 
     # This has to be last as we use a CTE as an optimization fence
-    # for counts by passing the force_cte param and enabling the
-    # attempt_group_search_optimizations feature flag
+    # for counts by passing the force_cte param
     # https://www.postgresql.org/docs/current/static/queries-with.html
     items = by_search(items)
 

spec/controllers/groups_controller_spec.rb

@@ -422,10 +422,6 @@ RSpec.describe GroupsController do
     end
 
     context 'searching' do
-      before do
-        stub_feature_flags(attempt_group_search_optimizations: true)
-      end
-
       it 'works with popularity sort' do
         get :issues, params: { id: group.to_param, search: 'foo', sort: 'popularity' }
 

spec/finders/issues_finder_spec.rb

@@ -949,10 +949,6 @@ RSpec.describe IssuesFinder do
   describe '#use_cte_for_search?' do
     let(:finder) { described_class.new(nil, params) }
 
-    before do
-      stub_feature_flags(attempt_group_search_optimizations: true)
-    end
-
     context 'when there is no search param' do
       let(:params) { { attempt_group_search_optimizations: true } }
 
@@ -969,18 +965,6 @@ RSpec.describe IssuesFinder do
       end
     end
 
-    context 'when the attempt_group_search_optimizations flag is disabled' do
-      let(:params) { { search: 'foo', attempt_group_search_optimizations: true } }
-
-      before do
-        stub_feature_flags(attempt_group_search_optimizations: false)
-      end
-
-      it 'returns false' do
-        expect(finder.use_cte_for_search?).to be_falsey
-      end
-    end
-
     context 'when attempt_group_search_optimizations is unset and attempt_project_search_optimizations is set' do
       let(:params) { { search: 'foo', attempt_project_search_optimizations: true } }