Adding a new metric for total highlighting attempts

lib/gitlab/highlight.rb

@@ -32,8 +32,12 @@ module Gitlab
     def highlight(text, continue: false, plain: false, context: {})
       @context = context
 
+      add_highlight_attempt_metric
+
       plain ||= self.class.too_large?(text.length)
 
+      highlight_timeout.increment(source: Gitlab::Runtime.sidekiq? ? "background" : "foreground")
+
       highlighted_text = highlight_text(text, continue: continue, plain: plain)
       highlighted_text = link_dependencies(text, highlighted_text) if blob_name
       highlighted_text
@@ -90,12 +94,25 @@ module Gitlab
       Gitlab::DependencyLinker.link(blob_name, text, highlighted_text)
     end
 
+    def add_highlight_attempt_metric
+      return unless Feature.enabled?(:track_highlight_timeouts)
+
+      highlighting_attempt.increment(source: @language || "undefined")
+    end
+
     def add_highlight_timeout_metric
       return unless Feature.enabled?(:track_highlight_timeouts)
 
       highlight_timeout.increment(source: Gitlab::Runtime.sidekiq? ? "background" : "foreground")
     end
 
+    def highlighting_attempt
+      @highlight_timeout ||= Gitlab::Metrics.counter(
+        :file_highlighting_attempt,
+        'Counts the times highlighting has been attempted on a file'
+      )
+    end
+
     def highlight_timeout
       @highlight_timeout ||= Gitlab::Metrics.counter(
         :highlight_timeout,

spec/lib/gitlab/highlight_spec.rb

@@ -143,6 +143,14 @@ RSpec.describe Gitlab::Highlight do
     end
 
     describe 'highlight timeouts' do
+      context 'when there is an attempt' do
+        let(:result) { described_class.highlight(file_name, content) }
+
+        it "increments the foreground counter if it's in the foreground" do
+          expect { result }.to change { highlight_attempt_total("undefined") }
+        end
+      end
+
       context 'when there is a timeout error while highlighting' do
         let(:result) { described_class.highlight(file_name, content) }
 
@@ -177,6 +185,12 @@ RSpec.describe Gitlab::Highlight do
       .get(source: source)
   end
 
+  def highlight_attempt_total(source)
+    Gitlab::Metrics
+      .counter(:file_highlighting_attempt, 'Counts the times highlighting has been attempted on a file')
+      .get(source: source)
+  end
+
   def over_highlight_size_limit(source)
     Gitlab::Metrics
       .counter(:over_highlight_size_limit,