Does not use magic finders since they are deprecated in AR 5

lib/gitlab/geo/file_downloader.rb

@@ -13,7 +13,7 @@ module Gitlab
       # Subclasses should return the number of bytes downloaded,
       # or nil or -1 if a failure occurred.
       def execute
-        upload = Upload.find_by_id(object_db_id)
+        upload = Upload.find_by(id: object_db_id)
         return unless upload.present?
 
         transfer = ::Gitlab::Geo::FileTransfer.new(object_type.to_sym, upload)

lib/gitlab/geo/file_uploader.rb

@@ -9,7 +9,7 @@ module Gitlab
       end
 
       def execute
-        recorded_file = Upload.find_by_id(object_db_id)
+        recorded_file = Upload.find_by(id: object_db_id)
 
         return error unless recorded_file&.exist?
         return error unless valid?(recorded_file)

lib/gitlab/geo/lfs_downloader.rb

@@ -2,7 +2,7 @@ module Gitlab
   module Geo
     class LfsDownloader < FileDownloader
       def execute
-        lfs_object = LfsObject.find_by_id(object_db_id)
+        lfs_object = LfsObject.find_by(id: object_db_id)
         return unless lfs_object.present?
 
         transfer = ::Gitlab::Geo::LfsTransfer.new(lfs_object)

lib/gitlab/geo/lfs_uploader.rb

@@ -2,7 +2,7 @@ module Gitlab
   module Geo
     class LfsUploader < FileUploader
       def execute
-        lfs_object = LfsObject.find(object_db_id)
+        lfs_object = LfsObject.find_by(id: object_db_id)
 
         return error unless lfs_object.present?
         return error if message[:sha256] != lfs_object.oid