Merge branch 'ek-replace-window-flash-function' into 'master'

Update window.Flash function

See merge request gitlab-org/gitlab!39784

app/assets/javascripts/flash.js

@@ -175,4 +175,4 @@ export {
   removeFlashClickListener,
   FLASH_TYPES,
 };
-window.Flash = deprecatedCreateFlash;
+window.Flash = createFlash;

app/views/profiles/preferences/update.js.erb

@@ -14,7 +14,7 @@ $('input[type=submit]').enable()
 
 // Show flash messages
 <% if flash.notice %>
-  new Flash('<%= flash.discard(:notice) %>', 'notice')
+  new Flash({ message: '<%= flash.discard(:notice) %>', type: 'notice'})
 <% elsif flash.alert %>
-  new Flash('<%= flash.discard(:alert) %>', 'alert')
+  new Flash({ message: '<%= flash.discard(:alert) %>', type: 'alert'})
 <% end %>

app/views/projects/tags/destroy.js.haml

 - if @error.present?
-  new Flash('#{escape_javascript(@error)}', 'alert');
+  new Flash({ message: '#{escape_javascript(@error)}', type: 'alert' });
 - elsif @repository.tags.empty?
   $('.tags').load(document.URL + ' .nothing-here-block').hide().fadeIn(1000)