Merge branch '239179-new-model-for-finding-evidences-add-ruby-limits' into 'master'

Add limits to ruby to match DB limits

See merge request gitlab-org/gitlab!61936

ee/app/models/vulnerabilities/findings/evidence.rb

@@ -9,6 +9,8 @@ module Vulnerabilities
 
       has_one :request, class_name: 'Vulnerabilities::Findings::Evidences::Request', inverse_of: :evidence, foreign_key: 'vulnerability_finding_evidence_id'
       has_one :response, class_name: 'Vulnerabilities::Findings::Evidences::Response', inverse_of: :evidence, foreign_key: 'vulnerability_finding_evidence_id'
+
+      validates :summary, length: { maximum: 8_000_000 }
     end
   end
 end

ee/app/models/vulnerabilities/findings/evidences/request.rb

@@ -7,6 +7,10 @@ module Vulnerabilities
         self.table_name = 'vulnerability_finding_evidence_requests'
 
         belongs_to :evidence, class_name: 'Vulnerabilities::Findings::Evidence', inverse_of: :request, foreign_key: 'vulnerability_finding_evidence_id', optional: false
+
+        validates :method, length: { maximum: 32 }
+        validates :url, length: { maximum: 2048 }
+        validates :body, length: { maximum: 2048 }
       end
     end
   end

ee/app/models/vulnerabilities/findings/evidences/response.rb

@@ -7,6 +7,9 @@ module Vulnerabilities
         self.table_name = 'vulnerability_finding_evidence_responses'
 
         belongs_to :evidence, class_name: 'Vulnerabilities::Findings::Evidence', inverse_of: :response, foreign_key: 'vulnerability_finding_evidence_id', optional: false
+
+        validates :reason_phrase, length: { maximum: 2048 }
+        validates :body, length: { maximum: 2048 }
       end
     end
   end

ee/spec/models/vulnerabilities/findings/evidence_spec.rb

@@ -6,4 +6,6 @@ RSpec.describe Vulnerabilities::Findings::Evidence do
   it { is_expected.to belong_to(:finding).class_name('Vulnerabilities::Finding').required }
   it { is_expected.to have_one(:request).class_name('Vulnerabilities::Findings::Evidences::Request').with_foreign_key('vulnerability_finding_evidence_id').inverse_of(:evidence) }
   it { is_expected.to have_one(:response).class_name('Vulnerabilities::Findings::Evidences::Response').with_foreign_key('vulnerability_finding_evidence_id').inverse_of(:evidence) }
+
+  it { is_expected.to validate_length_of(:summary).is_at_most(8_000_000) }
 end

ee/spec/models/vulnerabilities/findings/evidences/request_spec.rb

@@ -4,4 +4,8 @@ require 'spec_helper'
 
 RSpec.describe Vulnerabilities::Findings::Evidences::Request do
   it { is_expected.to belong_to(:evidence).class_name('Vulnerabilities::Findings::Evidence').inverse_of(:request).required }
+
+  it { is_expected.to validate_length_of(:method).is_at_most(32) }
+  it { is_expected.to validate_length_of(:url).is_at_most(2048) }
+  it { is_expected.to validate_length_of(:body).is_at_most(2048) }
 end

ee/spec/models/vulnerabilities/findings/evidences/response_spec.rb

@@ -4,4 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Vulnerabilities::Findings::Evidences::Response do
   it { is_expected.to belong_to(:evidence).class_name('Vulnerabilities::Findings::Evidence').inverse_of(:response).required }
+
+  it { is_expected.to validate_length_of(:reason_phrase).is_at_most(2048) }
+  it { is_expected.to validate_length_of(:body).is_at_most(2048) }
 end