Merge branch 'jnnkl-remove-initial-eventlisteners' into 'master'

Remove obsolete DOMContentLoadedEventListener

See merge request gitlab-org/gitlab!67436

app/assets/javascripts/pages/dashboard/merge_requests/index.js

@@ -4,14 +4,12 @@ import { FILTERED_SEARCH } from '~/pages/constants';
 import initFilteredSearch from '~/pages/search/init_filtered_search';
 import projectSelect from '~/project_select';
 
-document.addEventListener('DOMContentLoaded', () => {
-  addExtraTokensForMergeRequests(IssuableFilteredSearchTokenKeys, true);
+addExtraTokensForMergeRequests(IssuableFilteredSearchTokenKeys, true);
 
-  initFilteredSearch({
-    page: FILTERED_SEARCH.MERGE_REQUESTS,
-    filteredSearchTokenKeys: IssuableFilteredSearchTokenKeys,
-    useDefaultState: true,
-  });
-
-  projectSelect();
+initFilteredSearch({
+  page: FILTERED_SEARCH.MERGE_REQUESTS,
+  filteredSearchTokenKeys: IssuableFilteredSearchTokenKeys,
+  useDefaultState: true,
 });
+
+projectSelect();

app/assets/javascripts/pages/dashboard/milestones/index/index.js

 import projectSelect from '~/project_select';
 
-document.addEventListener('DOMContentLoaded', projectSelect);
+projectSelect();

app/assets/javascripts/pages/explore/groups/index.js

@@ -2,7 +2,7 @@ import GroupsList from '~/groups_list';
 import Landing from '~/landing';
 import initGroupsList from '../../../groups';
 
-document.addEventListener('DOMContentLoaded', () => {
+function exploreGroups() {
   new GroupsList(); // eslint-disable-line no-new
   initGroupsList();
   const landingElement = document.querySelector('.js-explore-groups-landing');
@@ -13,4 +13,6 @@ document.addEventListener('DOMContentLoaded', () => {
     'explore_groups_landing_dismissed',
   );
   exploreGroupsLanding.toggle();
-});
+}
+
+exploreGroups();

app/assets/javascripts/pages/help/index/index.js

@@ -2,7 +2,5 @@ import $ from 'jquery';
 import docs from '~/docs/docs_bundle';
 import VersionCheckImage from '~/version_check_image';
 
-document.addEventListener('DOMContentLoaded', () => {
-  docs();
-  VersionCheckImage.bindErrorEvent($('img.js-version-status-badge'));
-});
+docs();
+VersionCheckImage.bindErrorEvent($('img.js-version-status-badge'));

app/assets/javascripts/pages/help/ui/index.js

 import initUIKit from '~/ui_development_kit';
 
-document.addEventListener('DOMContentLoaded', initUIKit);
+initUIKit();

app/assets/javascripts/pages/import/bitbucket/status/index.js

@@ -2,7 +2,7 @@ import Vue from 'vue';
 import { initStoreFromElement, initPropsFromElement } from '~/import_entities/import_projects';
 import BitbucketStatusTable from '~/import_entities/import_projects/components/bitbucket_status_table.vue';
 
-document.addEventListener('DOMContentLoaded', () => {
+function importBitBucket() {
   const mountElement = document.getElementById('import-projects-mount-element');
   if (!mountElement) return undefined;
 
@@ -16,4 +16,6 @@ document.addEventListener('DOMContentLoaded', () => {
       return createElement(BitbucketStatusTable, { attrs });
     },
   });
-});
+}
+
+importBitBucket();

app/assets/javascripts/pages/import/bitbucket_server/status/index.js

@@ -2,7 +2,7 @@ import Vue from 'vue';
 import { initStoreFromElement, initPropsFromElement } from '~/import_entities/import_projects';
 import BitbucketServerStatusTable from './components/bitbucket_server_status_table.vue';
 
-document.addEventListener('DOMContentLoaded', () => {
+function BitbucketServerStatus() {
   const mountElement = document.getElementById('import-projects-mount-element');
   if (!mountElement) return undefined;
 
@@ -19,4 +19,6 @@ document.addEventListener('DOMContentLoaded', () => {
       });
     },
   });
-});
+}
+
+BitbucketServerStatus();

app/assets/javascripts/pages/import/gitea/status/index.js

 import mountImportProjectsTable from '~/import_entities/import_projects';
 
-document.addEventListener('DOMContentLoaded', () => {
-  const mountElement = document.getElementById('import-projects-mount-element');
+const mountElement = document.getElementById('import-projects-mount-element');
 
-  mountImportProjectsTable(mountElement);
-});
+mountImportProjectsTable(mountElement);

app/assets/javascripts/pages/import/gitlab/status/index.js

 import mountImportProjectsTable from '~/import_entities/import_projects';
 
-document.addEventListener('DOMContentLoaded', () => {
-  const mountElement = document.getElementById('import-projects-mount-element');
+const mountElement = document.getElementById('import-projects-mount-element');
 
-  mountImportProjectsTable(mountElement);
-});
+mountImportProjectsTable(mountElement);

app/assets/javascripts/pages/import/gitlab_projects/new/index.js

 import initGitLabImportProject from '~/projects/project_import_gitlab_project';
 
-document.addEventListener('DOMContentLoaded', initGitLabImportProject);
+initGitLabImportProject();

app/assets/javascripts/pages/import/manifest/status/index.js

 import mountImportProjectsTable from '~/import_entities/import_projects';
 
-document.addEventListener('DOMContentLoaded', () => {
-  const mountElement = document.getElementById('import-projects-mount-element');
+const mountElement = document.getElementById('import-projects-mount-element');
 
-  mountImportProjectsTable(mountElement);
-});
+mountImportProjectsTable(mountElement);

app/assets/javascripts/pages/omniauth_callbacks/index.js

 import { mount2faAuthentication } from '~/authentication/mount_2fa';
 
-document.addEventListener('DOMContentLoaded', mount2faAuthentication);
+mount2faAuthentication();

app/assets/javascripts/pages/projects/services/edit/index.js

@@ -2,16 +2,14 @@ import IntegrationSettingsForm from '~/integrations/integration_settings_form';
 import PrometheusAlerts from '~/prometheus_alerts';
 import CustomMetrics from '~/prometheus_metrics/custom_metrics';
 
-document.addEventListener('DOMContentLoaded', () => {
-  const integrationSettingsForm = new IntegrationSettingsForm('.js-integration-settings-form');
-  integrationSettingsForm.init();
+const integrationSettingsForm = new IntegrationSettingsForm('.js-integration-settings-form');
+integrationSettingsForm.init();
 
-  const prometheusSettingsSelector = '.js-prometheus-metrics-monitoring';
-  const prometheusSettingsWrapper = document.querySelector(prometheusSettingsSelector);
-  if (prometheusSettingsWrapper) {
-    const customMetrics = new CustomMetrics(prometheusSettingsSelector);
-    customMetrics.init();
-  }
+const prometheusSettingsSelector = '.js-prometheus-metrics-monitoring';
+const prometheusSettingsWrapper = document.querySelector(prometheusSettingsSelector);
+if (prometheusSettingsWrapper) {
+  const customMetrics = new CustomMetrics(prometheusSettingsSelector);
+  customMetrics.init();
+}
 
-  PrometheusAlerts();
-});
+PrometheusAlerts();

app/assets/javascripts/pages/sessions/index.js

 import { mount2faAuthentication } from '~/authentication/mount_2fa';
 
-document.addEventListener('DOMContentLoaded', mount2faAuthentication);
+mount2faAuthentication();

app/assets/javascripts/pages/sessions/new/index.js

@@ -7,18 +7,16 @@ import preserveUrlFragment from './preserve_url_fragment';
 import SigninTabsMemoizer from './signin_tabs_memoizer';
 import UsernameValidator from './username_validator';
 
-document.addEventListener('DOMContentLoaded', () => {
-  new UsernameValidator(); // eslint-disable-line no-new
-  new LengthValidator(); // eslint-disable-line no-new
-  new SigninTabsMemoizer(); // eslint-disable-line no-new
-  new NoEmojiValidator(); // eslint-disable-line no-new
+new UsernameValidator(); // eslint-disable-line no-new
+new LengthValidator(); // eslint-disable-line no-new
+new SigninTabsMemoizer(); // eslint-disable-line no-new
+new NoEmojiValidator(); // eslint-disable-line no-new
 
-  new OAuthRememberMe({
-    container: $('.omniauth-container'),
-  }).bindEvents();
+new OAuthRememberMe({
+  container: $('.omniauth-container'),
+}).bindEvents();
 
-  // Save the URL fragment from the current window location. This will be present if the user was
-  // redirected to sign-in after attempting to access a protected URL that included a fragment.
-  preserveUrlFragment(window.location.hash);
-  initVueAlerts();
-});
+// Save the URL fragment from the current window location. This will be present if the user was
+// redirected to sign-in after attempting to access a protected URL that included a fragment.
+preserveUrlFragment(window.location.hash);
+initVueAlerts();