Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1c8a6969
Commit
1c8a6969
authored
Jul 29, 2019
by
lauraMon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Binds computed title to component
parent
6f9038ea
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
1 deletion
+12
-1
ee/app/assets/javascripts/operations/components/dashboard/project_header.vue
...cripts/operations/components/dashboard/project_header.vue
+1
-1
ee/changelogs/unreleased/13144-operation-dashboard-delete-icon-tooltip-should-not-say-title.yml
...on-dashboard-delete-icon-tooltip-should-not-say-title.yml
+5
-0
ee/spec/javascripts/operations/components/dashboard/project_header_spec.js
...ts/operations/components/dashboard/project_header_spec.js
+6
-0
No files found.
ee/app/assets/javascripts/operations/components/dashboard/project_header.vue
View file @
1c8a6969
...
...
@@ -67,7 +67,7 @@ export default {
<gl-button
v-gl-tooltip
class=
"js-remove-button bg-transparent border-0 p-0 text-secondary"
title=
"title"
:
title=
"title"
@
click=
"onRemove"
>
<icon
name=
"remove"
/>
...
...
ee/changelogs/unreleased/13144-operation-dashboard-delete-icon-tooltip-should-not-say-title.yml
0 → 100644
View file @
1c8a6969
---
title
:
'
fix:
operation
dashboard
delete
icon
tooltip
title'
merge_request
:
14899
author
:
type
:
fixed
ee/spec/javascripts/operations/components/dashboard/project_header_spec.js
View file @
1c8a6969
...
...
@@ -46,6 +46,12 @@ describe('project header component', () => {
expect
(
wrapper
.
contains
(
'
.js-remove-button
'
)).
toBe
(
true
);
});
it
(
'
renders correct title for removal icon
'
,
()
=>
{
const
button
=
wrapper
.
find
(
'
.js-remove-button
'
);
expect
(
button
.
attributes
(
'
data-original-title
'
)).
toBe
(
'
Remove card
'
);
});
it
(
'
emits project removal link on click
'
,
()
=>
{
wrapper
.
find
(
'
.js-remove-button
'
).
vm
.
$emit
(
'
click
'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment