Commit 1c95ebb6 authored by Rémy Coutable's avatar Rémy Coutable

Merge branch '228703-nil-check-mr-author' into 'master'

Check for mr_author nil in danger QA rule

See merge request gitlab-org/gitlab!36761
parents 041e04a8 f855176e
...@@ -81,7 +81,7 @@ if changes.any? ...@@ -81,7 +81,7 @@ if changes.any?
roulette_spins = roulette.spin(project, categories, branch_name, timezone_experiment: TIMEZONE_EXPERIMENT) roulette_spins = roulette.spin(project, categories, branch_name, timezone_experiment: TIMEZONE_EXPERIMENT)
rows = roulette_spins.map do |spin| rows = roulette_spins.map do |spin|
# MR includes QA changes, but also other changes, and author isn't an SET # MR includes QA changes, but also other changes, and author isn't an SET
if spin.category == :qa && categories.size > 1 && !mr_author.reviewer?(project, spin.category, []) if spin.category == :qa && categories.size > 1 && mr_author && !mr_author.reviewer?(project, spin.category, [])
spin.optional_role = :maintainer spin.optional_role = :maintainer
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment