Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1d595e9a
Commit
1d595e9a
authored
Mar 05, 2020
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Danger: don't require a review when 'database::approved' is set
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
f96750dd
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
0 deletions
+3
-0
danger/database/Dangerfile
danger/database/Dangerfile
+3
-0
No files found.
danger/database/Dangerfile
View file @
1d595e9a
...
@@ -29,6 +29,8 @@ DB_FILES_MESSAGE = <<~MSG
...
@@ -29,6 +29,8 @@ DB_FILES_MESSAGE = <<~MSG
The following files require a review from the Database team:
The following files require a review from the Database team:
MSG
MSG
DATABASE_APPROVED_LABEL
=
'database::approved'
non_geo_db_schema_updated
=
!
git
.
modified_files
.
grep
(
%r{
\A
db/schema
\.
rb}
).
empty?
non_geo_db_schema_updated
=
!
git
.
modified_files
.
grep
(
%r{
\A
db/schema
\.
rb}
).
empty?
geo_db_schema_updated
=
!
git
.
modified_files
.
grep
(
%r{
\A
ee/db/geo/schema
\.
rb}
).
empty?
geo_db_schema_updated
=
!
git
.
modified_files
.
grep
(
%r{
\A
ee/db/geo/schema
\.
rb}
).
empty?
...
@@ -46,6 +48,7 @@ if geo_migration_created && !geo_db_schema_updated
...
@@ -46,6 +48,7 @@ if geo_migration_created && !geo_db_schema_updated
end
end
return
unless
gitlab_danger
.
ci?
return
unless
gitlab_danger
.
ci?
return
if
gitlab
.
mr_labels
.
include?
(
DATABASE_APPROVED_LABEL
)
db_paths_to_review
=
helper
.
changes_by_category
[
:database
]
db_paths_to_review
=
helper
.
changes_by_category
[
:database
]
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment