Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1e17b30f
Commit
1e17b30f
authored
Jun 26, 2018
by
Nick Thomas
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove the geo_redownload_with_snapshot feature flag
parent
9bebb7f5
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
35 deletions
+5
-35
ee/app/services/geo/base_sync_service.rb
ee/app/services/geo/base_sync_service.rb
+0
-2
ee/changelogs/unreleased/6692-remove-geo-redownload-feature-flag.yml
...gs/unreleased/6692-remove-geo-redownload-feature-flag.yml
+5
-0
ee/spec/support/services/base_sync_service_shared_examples.rb
...pec/support/services/base_sync_service_shared_examples.rb
+0
-33
No files found.
ee/app/services/geo/base_sync_service.rb
View file @
1e17b30f
...
...
@@ -117,8 +117,6 @@ module Geo
# will be enqueued by the log cursor, which should resolve any problems
# it is possible to fix.
def
fetch_snapshot
return
unless
Feature
.
enabled?
(
:geo_redownload_with_snapshot
)
log_info
(
"Attempting to fetch repository via snapshot"
)
temp_repo
.
create_from_snapshot
(
...
...
ee/changelogs/unreleased/6692-remove-geo-redownload-feature-flag.yml
0 → 100644
View file @
1e17b30f
---
title
:
Enable Geo snapshot synchronization for everyone
merge_request
:
6286
author
:
type
:
other
ee/spec/support/services/base_sync_service_shared_examples.rb
View file @
1e17b30f
...
...
@@ -74,30 +74,6 @@ shared_examples 'geo base sync fetch and repack' do
fetch_repository
end
context
'redownload'
do
let
(
:fetch_repository
)
{
subject
.
send
(
:fetch_repository
,
true
)
}
before
do
stub_feature_flags
(
geo_redownload_with_snapshot:
false
)
end
it
'fetches repository from geo node into temporary location'
do
temporary_repository
=
instance_double
(
'Repository'
)
is_expected
.
to
receive
(
:temp_repo
)
{
temporary_repository
}
is_expected
.
to
receive
(
:fetch_geo_mirror
).
with
(
temporary_repository
)
is_expected
.
to
receive
(
:set_temp_repository_as_main
)
fetch_repository
end
it
'schedule git repack'
do
is_expected
.
to
receive
(
:schedule_repack
)
fetch_repository
end
end
context
'repository does not exist'
do
before
do
allow_any_instance_of
(
Repository
).
to
receive
(
:exists?
)
{
false
}
...
...
@@ -162,15 +138,6 @@ shared_examples 'sync retries use the snapshot RPC' do
subject
.
execute
end
it
'does not attempt to snapshot if the feature flag is disabled'
do
stub_feature_flags
(
geo_redownload_with_snapshot:
false
)
expect
(
repository
).
not_to
receive_create_from_snapshot
expect
(
subject
).
to
receive
(
:fetch_geo_mirror
).
with
(
repository
)
subject
.
execute
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment