Merge branch 'extract-vulnerabilities-finders-from-group' into 'master'

Make VulnerabilitiesFinder agnostic between Projects and Groups

See merge request gitlab-org/gitlab-ee!14471

ee/app/controllers/groups/security/vulnerabilities_controller.rb

@@ -44,6 +44,6 @@ class Groups::Security::VulnerabilitiesController < Groups::Security::Applicatio
   end
 
   def found_vulnerabilities(collection = :latest)
-    ::Security::VulnerabilitiesFinder.new(group: group, params: filter_params).execute(collection)
+    ::Security::VulnerabilitiesFinder.new(group, params: filter_params).execute(collection)
   end
 end

ee/app/finders/security/vulnerabilities_finder.rb

@@ -5,7 +5,7 @@
 # Used to filter Vulnerabilities::Occurrences  by set of params for Security Dashboard
 #
 # Arguments:
-#   group - object to filter vulnerabilities
+#   vulnerable - object to filter vulnerabilities
 #   params:
 #     severity: Array<String>
 #     confidence: Array<String>
@@ -15,10 +15,10 @@
 module Security
   class VulnerabilitiesFinder
     attr_accessor :params
-    attr_reader :group
+    attr_reader :vulnerable
 
-    def initialize(group:, params: {})
-      @group = group
+    def initialize(vulnerable, params: {})
+      @vulnerable = vulnerable
       @params = params
     end
 
@@ -65,11 +65,11 @@ module Security
 
     def init_collection(scope)
       if scope == :all
-        group.all_vulnerabilities
+        vulnerable.all_vulnerabilities
       elsif scope == :with_sha
-        group.latest_vulnerabilities_with_sha
+        vulnerable.latest_vulnerabilities_with_sha
       else
-        group.latest_vulnerabilities
+        vulnerable.latest_vulnerabilities
       end
     end
   end

ee/spec/finders/security/vulnerabilities_finder_spec.rb

@@ -15,7 +15,7 @@ describe Security::VulnerabilitiesFinder do
     set(:vulnerability3) { create(:vulnerabilities_occurrence, report_type: :sast, severity: :low, pipelines: [pipeline2], project: project2) }
     set(:vulnerability4) { create(:vulnerabilities_occurrence, report_type: :dast, severity: :medium, pipelines: [pipeline1], project: project1) }
 
-    subject { described_class.new(group: group, params: params).execute }
+    subject { described_class.new(group, params: params).execute }
 
     context 'by report type' do
       context 'when sast' do