Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1eab0657
Commit
1eab0657
authored
Jul 23, 2019
by
Matija Čupić
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add specs for latest_successful methods for SHAs
parent
7cee6139
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
68 additions
and
0 deletions
+68
-0
spec/models/ci/pipeline_spec.rb
spec/models/ci/pipeline_spec.rb
+13
-0
spec/models/project_spec.rb
spec/models/project_spec.rb
+55
-0
No files found.
spec/models/ci/pipeline_spec.rb
View file @
1eab0657
...
...
@@ -1812,6 +1812,19 @@ describe Ci::Pipeline, :mailer do
end
end
describe
'.latest_successful_for_sha'
do
include_context
'with some outdated pipelines'
let!
(
:latest_successful_pipeline
)
do
create_pipeline
(
:success
,
'ref'
,
'awesomesha'
,
project
)
end
it
'returns the latest successful pipeline'
do
expect
(
described_class
.
latest_successful_for_sha
(
'awesomesha'
))
.
to
eq
(
latest_successful_pipeline
)
end
end
describe
'.latest_successful_for_refs'
do
include_context
'with some outdated pipelines'
...
...
spec/models/project_spec.rb
View file @
1eab0657
...
...
@@ -2074,6 +2074,61 @@ describe Project do
end
end
describe
'#latest_successful_build_for_sha'
do
let
(
:project
)
{
create
(
:project
,
:repository
)
}
let
(
:pipeline
)
{
create_pipeline
(
project
)
}
context
'with many builds'
do
it
'gives the latest builds from latest pipeline'
do
pipeline1
=
create_pipeline
(
project
)
pipeline2
=
create_pipeline
(
project
)
create_build
(
pipeline1
,
'test'
)
create_build
(
pipeline1
,
'test2'
)
build1_p2
=
create_build
(
pipeline2
,
'test'
)
create_build
(
pipeline2
,
'test2'
)
expect
(
project
.
latest_successful_build_for_sha
(
build1_p2
.
name
))
.
to
eq
(
build1_p2
)
end
end
context
'with succeeded pipeline'
do
let!
(
:build
)
{
create_build
}
context
'standalone pipeline'
do
it
'returns builds for ref for default_branch'
do
expect
(
project
.
latest_successful_build_for_sha
(
build
.
name
))
.
to
eq
(
build
)
end
it
'returns empty relation if the build cannot be found'
do
expect
(
project
.
latest_successful_build_for_sha
(
'TAIL'
))
.
to
be_nil
end
end
context
'with some pending pipeline'
do
before
do
create_build
(
create_pipeline
(
project
,
'pending'
))
end
it
'gives the latest build from latest pipeline'
do
expect
(
project
.
latest_successful_build_for_sha
(
build
.
name
))
.
to
eq
(
build
)
end
end
end
context
'with pending pipeline'
do
it
'returns empty relation'
do
pipeline
.
update
(
status:
'pending'
)
pending_build
=
create_build
(
pipeline
)
expect
(
project
.
latest_successful_build_for_sha
(
pending_build
.
name
)).
to
be_nil
end
end
end
describe
'#latest_successful_build_for!'
do
let
(
:project
)
{
create
(
:project
,
:repository
)
}
let
(
:pipeline
)
{
create_pipeline
(
project
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment