Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1ead617c
Commit
1ead617c
authored
Apr 30, 2021
by
Amy Qualls
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Complete CTRT rewrite of approvals page
parent
e8aec7f5
Changes
5
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
88 additions
and
75 deletions
+88
-75
doc/development/code_review.md
doc/development/code_review.md
+1
-1
doc/user/project/merge_requests/approvals/img/approve.png
doc/user/project/merge_requests/approvals/img/approve.png
+0
-0
doc/user/project/merge_requests/approvals/img/approve_additionally.png
...ect/merge_requests/approvals/img/approve_additionally.png
+0
-0
doc/user/project/merge_requests/approvals/img/remove_approval.png
.../project/merge_requests/approvals/img/remove_approval.png
+0
-0
doc/user/project/merge_requests/approvals/index.md
doc/user/project/merge_requests/approvals/index.md
+87
-74
No files found.
doc/development/code_review.md
View file @
1ead617c
...
@@ -39,7 +39,7 @@ or more [maintainers](https://about.gitlab.com/handbook/engineering/workflow/cod
...
@@ -39,7 +39,7 @@ or more [maintainers](https://about.gitlab.com/handbook/engineering/workflow/cod
For approvals, we use the approval functionality found in the merge request
For approvals, we use the approval functionality found in the merge request
widget. For reviewers, we use the
[
reviewer functionality
](
../user/project/merge_requests/getting_started.md#reviewer
)
in the sidebar.
widget. For reviewers, we use the
[
reviewer functionality
](
../user/project/merge_requests/getting_started.md#reviewer
)
in the sidebar.
Reviewers can add their approval by
[
approving additionally
](
../user/project/merge_requests/approvals/index.md#a
dding-or-removing-an-approval
)
.
Reviewers can add their approval by
[
approving additionally
](
../user/project/merge_requests/approvals/index.md#a
pprove-a-merge-request
)
.
Getting your merge request
**merged**
also requires a maintainer. If it requires
Getting your merge request
**merged**
also requires a maintainer. If it requires
more than one approval, the last maintainer to review and approve merges it.
more than one approval, the last maintainer to review and approve merges it.
...
...
doc/user/project/merge_requests/approvals/img/approve.png
deleted
100644 → 0
View file @
e8aec7f5
6.5 KB
doc/user/project/merge_requests/approvals/img/approve_additionally.png
deleted
100644 → 0
View file @
e8aec7f5
7.62 KB
doc/user/project/merge_requests/approvals/img/remove_approval.png
deleted
100644 → 0
View file @
e8aec7f5
7.36 KB
doc/user/project/merge_requests/approvals/index.md
View file @
1ead617c
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment