Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1f1d5e86
Commit
1f1d5e86
authored
Feb 17, 2021
by
Mike Greiling
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update accessibility for reply placeholder
parent
ff0822ae
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
4 deletions
+5
-4
app/assets/javascripts/design_management/components/design_notes/design_discussion.vue
..._management/components/design_notes/design_discussion.vue
+1
-1
app/assets/javascripts/notes/components/discussion_actions.vue
...ssets/javascripts/notes/components/discussion_actions.vue
+1
-1
app/assets/javascripts/notes/components/discussion_reply_placeholder.vue
...scripts/notes/components/discussion_reply_placeholder.vue
+2
-1
app/assets/javascripts/notes/components/note_form.vue
app/assets/javascripts/notes/components/note_form.vue
+1
-1
No files found.
app/assets/javascripts/design_management/components/design_notes/design_discussion.vue
View file @
1f1d5e86
...
...
@@ -257,7 +257,7 @@ export default {
<reply-placeholder
v-if=
"!isFormVisible"
class=
"qa-discussion-reply"
:placeholder-text=
"__('Reply
...
')"
:placeholder-text=
"__('Reply
…
')"
@
focus=
"showForm"
/>
<apollo-mutation
...
...
app/assets/javascripts/notes/components/discussion_actions.vue
View file @
1f1d5e86
...
...
@@ -50,7 +50,7 @@ export default {
<div
class=
"discussion-with-resolve-btn clearfix"
>
<reply-placeholder
data-qa-selector=
"discussion_reply_tab"
:placeholder-text=
"
s__('MergeRequests|Reply...
')"
:placeholder-text=
"
__('Reply…
')"
@
focus=
"$emit('showReplyForm')"
/>
...
...
app/assets/javascripts/notes/components/discussion_reply_placeholder.vue
View file @
1f1d5e86
...
...
@@ -15,7 +15,8 @@ export default {
rows=
"1"
class=
"reply-placeholder-text-field js-vue-discussion-reply"
:placeholder=
"placeholderText"
:title=
"s__('MergeRequests|Add a reply')"
:title=
"__('Reply to comment')"
:aria-label=
"__('Reply to comment')"
@
focus=
"$emit('focus')"
></textarea>
</
template
>
app/assets/javascripts/notes/components/note_form.vue
View file @
1f1d5e86
...
...
@@ -345,7 +345,7 @@ export default {
class=
"note-textarea js-gfm-input js-note-text js-autosize markdown-area js-vue-issue-note-form"
data-qa-selector=
"reply_field"
dir=
"auto"
:aria-label=
"__('
Description
')"
:aria-label=
"__('
Reply to comment
')"
:placeholder=
"__('Write a comment or drag your files here…')"
@
keydown.meta.enter=
"handleKeySubmit()"
@
keydown.ctrl.enter=
"handleKeySubmit()"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment