Commit 1f4acbb1 authored by Heinrich Lee Yu's avatar Heinrich Lee Yu

Fix flaky todo finder spec

We must pass a type when filtering by target_id because it could
match other models having the same ID
parent 42f472da
...@@ -235,15 +235,18 @@ RSpec.describe TodosFinder do ...@@ -235,15 +235,18 @@ RSpec.describe TodosFinder do
context 'when filtering by target id' do context 'when filtering by target id' do
it 'returns the expected todos for the target' do it 'returns the expected todos for the target' do
todos = finder.new(user, { target_id: issue.id }).execute todos = finder.new(user, { type: 'Issue', target_id: issue.id }).execute
expect(todos).to match_array([todo1]) expect(todos).to match_array([todo1])
end end
it 'returns the expected todos for multiple target ids' do it 'returns the expected todos for multiple target ids' do
todos = finder.new(user, { target_id: [issue.id, merge_request.id] }).execute another_issue = create(:issue, project: project)
todo3 = create(:todo, user: user, project: project, target: another_issue)
expect(todos).to match_array([todo1, todo2]) todos = finder.new(user, { type: 'Issue', target_id: [issue.id, another_issue.id] }).execute
expect(todos).to match_array([todo1, todo3])
end end
it 'returns the expected todos for empty target id collection' do it 'returns the expected todos for empty target id collection' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment