Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1f614f82
Commit
1f614f82
authored
Aug 26, 2020
by
Jarek Ostrowski
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update commit toggle description
MR:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40524
parent
c6a57cc1
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
11 additions
and
8 deletions
+11
-8
app/assets/javascripts/diffs/components/commit_item.vue
app/assets/javascripts/diffs/components/commit_item.vue
+5
-6
changelogs/unreleased/229336-diffs-collapsible-button.yml
changelogs/unreleased/229336-diffs-collapsible-button.yml
+5
-0
spec/frontend/diffs/components/commit_item_spec.js
spec/frontend/diffs/components/commit_item_spec.js
+1
-2
No files found.
app/assets/javascripts/diffs/components/commit_item.vue
View file @
1f614f82
...
...
@@ -149,14 +149,13 @@ export default {
<span
class=
"commit-row-message d-block d-sm-none"
>
·
{{
commit
.
short_id
}}
</span>
<button
<
gl-
button
v-if=
"commit.description_html && collapsible"
class=
"text-expander js-toggle-button"
type=
"button"
class=
"js-toggle-button"
size=
"small"
icon=
"ellipsis_h"
:aria-label=
"__('Toggle commit description')"
>
<gl-icon
:size=
"12"
name=
"ellipsis_h"
/>
</button>
/>
<div
class=
"committer"
>
<a
...
...
changelogs/unreleased/229336-diffs-collapsible-button.yml
0 → 100644
View file @
1f614f82
---
title
:
Update commit toggle description button to gl-button
merge_request
:
40524
author
:
type
:
changed
spec/frontend/diffs/components/commit_item_spec.js
View file @
1f614f82
...
...
@@ -24,8 +24,7 @@ describe('diffs/components/commit_item', () => {
const
getTitleElement
=
()
=>
wrapper
.
find
(
'
.commit-row-message.item-title
'
);
const
getDescElement
=
()
=>
wrapper
.
find
(
'
pre.commit-row-description
'
);
const
getDescExpandElement
=
()
=>
wrapper
.
find
(
'
.commit-content .text-expander.js-toggle-button
'
);
const
getDescExpandElement
=
()
=>
wrapper
.
find
(
'
.commit-content .js-toggle-button
'
);
const
getShaElement
=
()
=>
wrapper
.
find
(
'
.commit-sha-group
'
);
const
getAvatarElement
=
()
=>
wrapper
.
find
(
'
.user-avatar-link
'
);
const
getCommitterElement
=
()
=>
wrapper
.
find
(
'
.committer
'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment