Merge branch '340099-remove-the-feature-flag' into 'master'

NPM performance fix: remove feature flag

See merge request gitlab-org/gitlab!70173

config/feature_flags/development/npm_finder_query_avoid_duplicated_conditions.yml

----
-name: npm_finder_query_avoid_duplicated_conditions
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/69572
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/340099
-milestone: '14.3'
-type: development
-group: group::package
-default_enabled: false

lib/api/helpers/packages/npm.rb

@@ -60,7 +60,7 @@ module API
               finder = ::Packages::Npm::PackageFinder.new(
                 package_name,
                 namespace: namespace,
-                last_of_each_version: Feature.disabled?(:npm_finder_query_avoid_duplicated_conditions)
+                last_of_each_version: false
               )
 
               finder.last&.project_id

spec/requests/api/npm_instance_packages_spec.rb

@@ -10,39 +10,27 @@ RSpec.describe API::NpmInstancePackages do
 
   include_context 'npm api setup'
 
-  shared_examples 'handling all endpoints' do
-    describe 'GET /api/v4/packages/npm/*package_name' do
-      it_behaves_like 'handling get metadata requests', scope: :instance do
-        let(:url) { api("/packages/npm/#{package_name}") }
-      end
-    end
-
-    describe 'GET /api/v4/packages/npm/-/package/*package_name/dist-tags' do
-      it_behaves_like 'handling get dist tags requests', scope: :instance do
-        let(:url) { api("/packages/npm/-/package/#{package_name}/dist-tags") }
-      end
+  describe 'GET /api/v4/packages/npm/*package_name' do
+    it_behaves_like 'handling get metadata requests', scope: :instance do
+      let(:url) { api("/packages/npm/#{package_name}") }
     end
+  end
 
-    describe 'PUT /api/v4/packages/npm/-/package/*package_name/dist-tags/:tag' do
-      it_behaves_like 'handling create dist tag requests', scope: :instance do
-        let(:url) { api("/packages/npm/-/package/#{package_name}/dist-tags/#{tag_name}") }
-      end
+  describe 'GET /api/v4/packages/npm/-/package/*package_name/dist-tags' do
+    it_behaves_like 'handling get dist tags requests', scope: :instance do
+      let(:url) { api("/packages/npm/-/package/#{package_name}/dist-tags") }
     end
+  end
 
-    describe 'DELETE /api/v4/packages/npm/-/package/*package_name/dist-tags/:tag' do
-      it_behaves_like 'handling delete dist tag requests', scope: :instance do
-        let(:url) { api("/packages/npm/-/package/#{package_name}/dist-tags/#{tag_name}") }
-      end
+  describe 'PUT /api/v4/packages/npm/-/package/*package_name/dist-tags/:tag' do
+    it_behaves_like 'handling create dist tag requests', scope: :instance do
+      let(:url) { api("/packages/npm/-/package/#{package_name}/dist-tags/#{tag_name}") }
     end
   end
 
-  it_behaves_like 'handling all endpoints'
-
-  context 'with npm_finder_query_avoid_duplicated_conditions disabled' do
-    before do
-      stub_feature_flags(npm_finder_query_avoid_duplicated_conditions: false)
+  describe 'DELETE /api/v4/packages/npm/-/package/*package_name/dist-tags/:tag' do
+    it_behaves_like 'handling delete dist tag requests', scope: :instance do
+      let(:url) { api("/packages/npm/-/package/#{package_name}/dist-tags/#{tag_name}") }
     end
-
-    it_behaves_like 'handling all endpoints'
   end
 end