Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
20c2a70d
Commit
20c2a70d
authored
Apr 09, 2019
by
GitLab Bot
Browse files
Options
Browse Files
Download
Plain Diff
Automatic merge of gitlab-org/gitlab-ce master
parents
1567a65c
61ab1f73
Changes
8
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
9 additions
and
8 deletions
+9
-8
app/controllers/dashboard/projects_controller.rb
app/controllers/dashboard/projects_controller.rb
+1
-2
app/controllers/projects/branches_controller.rb
app/controllers/projects/branches_controller.rb
+1
-1
app/controllers/root_controller.rb
app/controllers/root_controller.rb
+1
-1
app/models/blob.rb
app/models/blob.rb
+1
-1
app/services/merge_requests/refresh_service.rb
app/services/merge_requests/refresh_service.rb
+2
-0
doc/development/gitaly.md
doc/development/gitaly.md
+1
-1
lib/banzai/filter/relative_link_filter.rb
lib/banzai/filter/relative_link_filter.rb
+1
-1
spec/features/issues/user_interacts_with_awards_spec.rb
spec/features/issues/user_interacts_with_awards_spec.rb
+1
-1
No files found.
app/controllers/dashboard/projects_controller.rb
View file @
20c2a70d
...
@@ -14,8 +14,7 @@ class Dashboard::ProjectsController < Dashboard::ApplicationController
...
@@ -14,8 +14,7 @@ class Dashboard::ProjectsController < Dashboard::ApplicationController
respond_to
do
|
format
|
respond_to
do
|
format
|
format
.
html
do
format
.
html
do
# n+1: https://gitlab.com/gitlab-org/gitlab-ce/issues/37434
# n+1: https://gitlab.com/gitlab-org/gitlab-ce/issues/40260
# Also https://gitlab.com/gitlab-org/gitlab-ce/issues/40260
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
do
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
do
render
render
end
end
...
...
app/controllers/projects/branches_controller.rb
View file @
20c2a70d
...
@@ -25,7 +25,7 @@ class Projects::BranchesController < Projects::ApplicationController
...
@@ -25,7 +25,7 @@ class Projects::BranchesController < Projects::ApplicationController
@refs_pipelines
=
@project
.
ci_pipelines
.
latest_successful_for_refs
(
@branches
.
map
(
&
:name
))
@refs_pipelines
=
@project
.
ci_pipelines
.
latest_successful_for_refs
(
@branches
.
map
(
&
:name
))
@merged_branch_names
=
repository
.
merged_branch_names
(
@branches
.
map
(
&
:name
))
@merged_branch_names
=
repository
.
merged_branch_names
(
@branches
.
map
(
&
:name
))
# n+1: https://gitlab.com/gitlab-org/git
aly/issues/992
# n+1: https://gitlab.com/gitlab-org/git
lab-ce/issues/48097
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
do
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
do
@max_commits
=
@branches
.
reduce
(
0
)
do
|
memo
,
branch
|
@max_commits
=
@branches
.
reduce
(
0
)
do
|
memo
,
branch
|
diverging_commit_counts
=
repository
.
diverging_commit_counts
(
branch
)
diverging_commit_counts
=
repository
.
diverging_commit_counts
(
branch
)
...
...
app/controllers/root_controller.rb
View file @
20c2a70d
...
@@ -15,7 +15,7 @@ class RootController < Dashboard::ProjectsController
...
@@ -15,7 +15,7 @@ class RootController < Dashboard::ProjectsController
before_action
:redirect_logged_user
,
if:
->
{
current_user
.
present?
}
before_action
:redirect_logged_user
,
if:
->
{
current_user
.
present?
}
def
index
def
index
# n+1: https://gitlab.com/gitlab-org/gitlab-ce/issues/
37434
# n+1: https://gitlab.com/gitlab-org/gitlab-ce/issues/
40260
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
do
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
do
super
super
end
end
...
...
app/models/blob.rb
View file @
20c2a70d
...
@@ -110,7 +110,7 @@ class Blob < SimpleDelegator
...
@@ -110,7 +110,7 @@ class Blob < SimpleDelegator
end
end
def
load_all_data!
def
load_all_data!
# Endpoint needed:
gitlab-org/gitaly#
756
# Endpoint needed:
https://gitlab.com/gitlab-org/gitaly/issues/
756
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
do
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
do
super
(
project
.
repository
)
if
project
super
(
project
.
repository
)
if
project
end
end
...
...
app/services/merge_requests/refresh_service.rb
View file @
20c2a70d
...
@@ -14,7 +14,9 @@ module MergeRequests
...
@@ -14,7 +14,9 @@ module MergeRequests
private
private
def
refresh_merge_requests!
def
refresh_merge_requests!
# n + 1: https://gitlab.com/gitlab-org/gitlab-ce/issues/60289
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
(
&
method
(
:find_new_commits
))
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
(
&
method
(
:find_new_commits
))
# Be sure to close outstanding MRs before reloading them to avoid generating an
# Be sure to close outstanding MRs before reloading them to avoid generating an
# empty diff during a manual merge
# empty diff during a manual merge
close_upon_missing_source_branch_ref
close_upon_missing_source_branch_ref
...
...
doc/development/gitaly.md
View file @
20c2a70d
...
@@ -6,7 +6,7 @@ Workhorse and GitLab-Shell.
...
@@ -6,7 +6,7 @@ Workhorse and GitLab-Shell.
## Beginner's guide
## Beginner's guide
Start by reading the gitaly repository's
Start by reading the gitaly repository's
[
Beginner's guide to Gitaly contributions
](
https://gitlab.com/gitlab-org/gitaly/blob/master/doc/beginners_guide.md
)
.
[
Beginner's guide to Gitaly contributions
](
https://gitlab.com/gitlab-org/gitaly/blob/master/doc/beginners_guide.md
)
.
It describes how to setup gitaly, the various components of gitaly and what they do, and how to run its test suites.
It describes how to setup gitaly, the various components of gitaly and what they do, and how to run its test suites.
## Developing new Git features
## Developing new Git features
...
...
lib/banzai/filter/relative_link_filter.rb
View file @
20c2a70d
...
@@ -150,7 +150,7 @@ module Banzai
...
@@ -150,7 +150,7 @@ module Banzai
end
end
def
uri_type
(
path
)
def
uri_type
(
path
)
# https://gitlab.com/gitlab-org/gitlab-ce/issues/58
011
# https://gitlab.com/gitlab-org/gitlab-ce/issues/58
657
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
do
Gitlab
::
GitalyClient
.
allow_n_plus_1_calls
do
@uri_types
[
path
]
||=
current_commit
.
uri_type
(
path
)
@uri_types
[
path
]
||=
current_commit
.
uri_type
(
path
)
end
end
...
...
spec/features/issues/user_interacts_with_awards_spec.rb
View file @
20c2a70d
...
@@ -14,7 +14,7 @@ describe 'User interacts with awards' do
...
@@ -14,7 +14,7 @@ describe 'User interacts with awards' do
visit
(
project_issue_path
(
project
,
issue
))
visit
(
project_issue_path
(
project
,
issue
))
end
end
it
'toggles the thumbsup award emoji'
do
it
'toggles the thumbsup award emoji'
,
:quarantine
do
page
.
within
(
'.awards'
)
do
page
.
within
(
'.awards'
)
do
thumbsup
=
page
.
first
(
'.award-control'
)
thumbsup
=
page
.
first
(
'.award-control'
)
thumbsup
.
click
thumbsup
.
click
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment